Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provider panics if sending VSCPackets fails #649

Closed
2 tasks done
mpoke opened this issue Jan 9, 2023 · 2 comments
Closed
2 tasks done

Provider panics if sending VSCPackets fails #649

mpoke opened this issue Jan 9, 2023 · 2 comments
Labels
type: feature-request New feature or request improvement

Comments

@mpoke
Copy link
Contributor

mpoke commented Jan 9, 2023

Problem

Currently, the provider attempts to send to every consumer VSCPackets in EndBlock. If the send fails, the provider panics, which means it will halt.

Closing criteria

Do not halt the chain when the sent fails.

TODOs

  • Labels have been added for issue
  • Issue has been added to the ICS project
@mpoke mpoke added the type: feature-request New feature or request improvement label Jan 9, 2023
@mpoke
Copy link
Contributor Author

mpoke commented Jan 27, 2023

Note that the same issue exists on the consumer side.

@mpoke mpoke added this to the ICS v1.1.0 milestone Jan 27, 2023
@mpoke mpoke added this to Cosmos Hub Jan 27, 2023
@github-project-automation github-project-automation bot moved this to 🩹 Triage in Cosmos Hub Jan 27, 2023
@andrey-kuprianov andrey-kuprianov mentioned this issue Feb 10, 2023
Closed
2 tasks
@mpoke mpoke modified the milestones: ICS v1.1.0, ICS next release Mar 5, 2023
@mpoke mpoke moved this from 🩹 Triage to 📥 Todo in Cosmos Hub Mar 5, 2023
@mpoke
Copy link
Contributor Author

mpoke commented Mar 13, 2023

Closing as duplicate of #731

@mpoke mpoke closed this as completed Mar 13, 2023
@github-project-automation github-project-automation bot moved this from 📥 Todo to ✅ Done in Cosmos Hub Mar 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type: feature-request New feature or request improvement
Projects
Cosmos Hub
Status: ✅ Done
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mpoke