Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add consumer chain timeout e2e/integration tests #674

Closed
1 of 2 tasks
MSalopek opened this issue Jan 18, 2023 · 3 comments
Closed
1 of 2 tasks

Add consumer chain timeout e2e/integration tests #674

MSalopek opened this issue Jan 18, 2023 · 3 comments
Labels
S: Productivity Productivity: Developer tooling, infrastructure improvements enabling future growth scope: testing Code review, testing, making sure the code is following the specification.

Comments

@MSalopek
Copy link
Contributor

Problem

Continuation of #361.

We should add a scenario that tests consumer timeouts and subsequent cleanup operations.

Closing criteria

Scenario is added to tests/integration

TODOs

  • Labels have been added for issue
  • Issue has been added to the ICS project
@MSalopek MSalopek added the scope: testing Code review, testing, making sure the code is following the specification. label Jan 18, 2023
@github-project-automation github-project-automation bot moved this to 🩹 Triage in Cosmos Hub Jan 18, 2023
@MSalopek MSalopek added this to the ICS v1.1.0 milestone Jan 18, 2023
@MSalopek MSalopek moved this from 🩹 Triage to 📥 Todo in Cosmos Hub Jan 18, 2023
@MSalopek MSalopek modified the milestones: ICS v1.1.0, ICS v1.0.0 Jan 18, 2023
@mpoke mpoke modified the milestones: ICS v1.0.0 , ICS v1.0.1 Feb 23, 2023
@mpoke mpoke removed this from the ICS v1.0.1 milestone Mar 5, 2023
@mpoke mpoke moved this from 📥 F2: Todo to 🩹 F1: Triage in Cosmos Hub Sep 13, 2023
@mpoke mpoke added the S: Productivity Productivity: Developer tooling, infrastructure improvements enabling future growth label Sep 13, 2023
@mpoke
Copy link
Contributor

mpoke commented Nov 16, 2023

@p-offtermatt How easy is to add this with CometMock?

@mpoke mpoke moved this from 🩹 F1: Triage to 📥 F2: Todo in Cosmos Hub Nov 16, 2023
@p-offtermatt
Copy link
Contributor

It should be very easy. The timeout part is trivial, knowing what to test with respect to cleanup is the part that I have uncertainty about.

@MSalopek
Copy link
Contributor Author

This was tested using cometmock.

@mpoke mpoke closed this as completed May 16, 2024
@github-project-automation github-project-automation bot moved this from 📥 F2: Todo to 👍 F4: Assessment in Cosmos Hub May 16, 2024
@mpoke mpoke moved this from 👍 F4: Assessment to ✅ Done in Cosmos Hub Jul 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
S: Productivity Productivity: Developer tooling, infrastructure improvements enabling future growth scope: testing Code review, testing, making sure the code is following the specification.
Projects
Cosmos Hub
Status: ✅ Done
Milestone
No milestone
Development

No branches or pull requests
3 participants
@mpoke @MSalopek @p-offtermatt