Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Distribution Total will always be empty in emitted events #720

Closed
AdityaSripal opened this issue Feb 7, 2023 · 0 comments · Fixed by #1097
Closed

Distribution Total will always be empty in emitted events #720

AdityaSripal opened this issue Feb 7, 2023 · 0 comments · Fixed by #1097
Assignees
@yaruwangway
Labels
good first issue Good for newcomers scope: UI Addressing UX changes and improvements to user interface source: audit To indicate an issue found during an audit.

Comments

@AdityaSripal
Copy link
Member

fpTokens are retrieved to emit events after all funds are already sent out, so it should always be empty

interchain-security/x/ccv/consumer/keeper/distribution.go

Line 21 in 463ec20

func (k Keeper) EndBlockRD(ctx sdk.Context) {

This function sends all funds out of the FeeCollector ModuleAccount:

interchain-security/x/ccv/consumer/keeper/distribution.go

Line 53 in 463ec20

func (k Keeper) DistributeRewardsInternally(ctx sdk.Context) {

This then gets called after which should return empty coins:

interchain-security/x/ccv/consumer/keeper/distribution.go

Line 131 in 463ec20

fpTokens := k.bankKeeper.GetAllBalances(ctx, consumerFeePoolAddr)

Thus this event is always going to just emit empty coins on the DistributionTotal attribute:

interchain-security/x/ccv/consumer/keeper/distribution.go

Line 145 in 463ec20

sdk.NewAttribute(ccv.AttributeDistributionTotal, fpTokens.String()),

@AdityaSripal AdityaSripal added the source: audit To indicate an issue found during an audit. label Feb 7, 2023
@mpoke mpoke mentioned this issue Feb 23, 2023
Closed
1 task
@mpoke mpoke added this to Cosmos Hub Feb 23, 2023
@github-project-automation github-project-automation bot moved this to 🩹 Triage in Cosmos Hub Feb 23, 2023
@mpoke mpoke added this to the ICS v1.0.1 milestone Feb 23, 2023
@mpoke mpoke moved this from 🩹 Triage to 📥 Todo in Cosmos Hub Feb 23, 2023
@mpoke mpoke modified the milestones: ICS v1.0.1, ICS next release Mar 5, 2023
@mpoke mpoke removed this from the ICS next release milestone Jun 20, 2023
@mpoke mpoke added scope: UI Addressing UX changes and improvements to user interface good first issue Good for newcomers labels Jun 20, 2023
@yaruwangway yaruwangway mentioned this issue Jun 28, 2023
Merged
20 tasks
@yaruwangway yaruwangway moved this from 📥 Todo to 🏗 In progress in Cosmos Hub Jun 28, 2023
@mpoke mpoke moved this from 🏗 In progress to 👀 In review in Cosmos Hub Jun 29, 2023
@github-project-automation github-project-automation bot moved this from 👀 In review to ✅ Done in Cosmos Hub Jul 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yaruwangway yaruwangway

Labels
good first issue Good for newcomers scope: UI Addressing UX changes and improvements to user interface source: audit To indicate an issue found during an audit.
Projects
Cosmos Hub
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: AttributeDistributionTotal in event emit cosmos/interchain-security
3 participants
@AdityaSripal @mpoke @yaruwangway