Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix!: introduce v4 provider migration code #1762

Merged
merged 1 commit into from
Apr 8, 2024

Conversation

MSalopek
Copy link
Contributor

@MSalopek MSalopek commented Apr 5, 2024

Epochs code changes the paramaters store, so the new parameter needs to be added to the store via a migration.

Had v4.0.0 and v4.1.0 stayed the same consensus version, provider chains using v4.0.0 would panic when migrating to v4.1.0 because of the missing migration.

To mitigate this issue provider consensus version got bumped to 4 and the migration code was refactored to introduce the v4 migration.

@MSalopek MSalopek self-assigned this Apr 5, 2024
@MSalopek MSalopek requested a review from a team as a code owner April 5, 2024 12:18
@github-actions github-actions bot added the C:x/provider Assigned automatically by the PR labeler label Apr 5, 2024
@MSalopek MSalopek added A:backport/v4.1.x state-machine-breaking State machine breaking changes (impacts consensus). scope: provider Issues related to the provider chain labels Apr 5, 2024
@sainoe sainoe self-requested a review April 8, 2024 08:29
@MSalopek MSalopek added this pull request to the merge queue Apr 8, 2024
Merged via the queue into main with commit 15d2d21 Apr 8, 2024
19 checks passed
@MSalopek MSalopek deleted the masa/v4-provider-consensus-version branch April 8, 2024 09:57
mergify bot pushed a commit that referenced this pull request Apr 8, 2024
mergify bot pushed a commit that referenced this pull request Apr 8, 2024
MSalopek added a commit that referenced this pull request Apr 8, 2024
fix!: introduce v4 provider migration code (#1762)

(cherry picked from commit 15d2d21)

Co-authored-by: MSalopek <matija.salopek994@gmail.com>
MSalopek added a commit that referenced this pull request Apr 8, 2024
fix!: introduce v4 provider migration code (#1762)

(cherry picked from commit 15d2d21)

Co-authored-by: MSalopek <matija.salopek994@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C:x/provider Assigned automatically by the PR labeler scope: provider Issues related to the provider chain state-machine-breaking State machine breaking changes (impacts consensus).
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants