-
Notifications
You must be signed in to change notification settings - Fork 133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix!: introduce v4 provider migration code #1762
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
C:x/provider
Assigned automatically by the PR labeler
label
Apr 5, 2024
MSalopek
added
A:backport/v4.1.x
state-machine-breaking
State machine breaking changes (impacts consensus).
scope: provider
Issues related to the provider chain
labels
Apr 5, 2024
12 tasks
insumity
reviewed
Apr 5, 2024
insumity
approved these changes
Apr 5, 2024
sainoe
approved these changes
Apr 8, 2024
mpoke
approved these changes
Apr 8, 2024
mergify bot
pushed a commit
that referenced
this pull request
Apr 8, 2024
(cherry picked from commit 15d2d21)
mergify bot
pushed a commit
that referenced
this pull request
Apr 8, 2024
(cherry picked from commit 15d2d21)
MSalopek
added a commit
that referenced
this pull request
Apr 8, 2024
MSalopek
added a commit
that referenced
this pull request
Apr 8, 2024
This was referenced Apr 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
C:x/provider
Assigned automatically by the PR labeler
scope: provider
Issues related to the provider chain
state-machine-breaking
State machine breaking changes (impacts consensus).
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Epochs code changes the paramaters store, so the new parameter needs to be added to the store via a migration.
Had v4.0.0 and v4.1.0 stayed the same consensus version, provider chains using v4.0.0 would panic when migrating to v4.1.0 because of the missing migration.
To mitigate this issue provider consensus version got bumped to
4
and the migration code was refactored to introduce thev4
migration.