Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

send button is still enabled even when extension is not installed #3330

Closed
jbibla opened this issue Dec 18, 2019 · 8 comments · Fixed by #3458
Closed

send button is still enabled even when extension is not installed #3330

jbibla opened this issue Dec 18, 2019 · 8 comments · Fixed by #3458
Assignees
Labels
bug 🐛 issues related to unhandled errors in the code that need to be fixed

Comments

@jbibla
Copy link
Collaborator

jbibla commented Dec 18, 2019

Describe the bug

if you select "extension" in an action modal as signing method, the message will ask the user to install the extension. however, the button is still enabled which means it can be "sent" even though this will never work.

Expected behavior

button should be disabled OR should be an "install" / "go to chrome store" button

@stale
Copy link

stale bot commented Jan 15, 2020

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@stale stale bot added the stale label Jan 15, 2020
@jbibla jbibla added the bug 🐛 issues related to unhandled errors in the code that need to be fixed label Jan 15, 2020
@stale stale bot removed the stale label Jan 15, 2020
@mariopino
Copy link
Contributor

Hi @jbibla, I can't reproduce this on Windows/Chrome/Brave.

At least in my test, Send button is disabled with the message "Waiting for extension".

image

@jbibla
Copy link
Collaborator Author

jbibla commented Jan 20, 2020

hmm. on mac with brave i can reproduce.

also, there should be some instructions, no?

@mariopino
Copy link
Contributor

I tested with extension disabled and uninstalled, I didn't see any instructions.

@faboweb
Copy link
Collaborator

faboweb commented Jan 20, 2020

I confirm that the Send button is enabled:
image

@faboweb
Copy link
Collaborator

faboweb commented Jan 20, 2020

Adding: I don't like this step and still propose that we make this step: "To continue please sign in to your address"

@jbibla
Copy link
Collaborator Author

jbibla commented Jan 21, 2020

I didn't see any instructions.

yeah this is a related bug. should be resolved.

@jbibla jbibla self-assigned this Jan 21, 2020
@jbibla
Copy link
Collaborator Author

jbibla commented Jan 21, 2020

i'm working on it now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 issues related to unhandled errors in the code that need to be fixed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants