Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address prefixes should be received from API #3402

Closed
faboweb opened this issue Jan 10, 2020 · 5 comments · Fixed by #3456
Closed

Address prefixes should be received from API #3402

faboweb opened this issue Jan 10, 2020 · 5 comments · Fixed by #3456

Comments

@faboweb
Copy link
Collaborator

faboweb commented Jan 10, 2020

Is your feature request related to a problem? Please describe.

To be able to scale networks without needing to update the client we should deliver as much data from the API as possible. Currently the bech 32 prefixes for the Ledger handling are in config.js. These should be received from the API (networks query). Same goes for identifying valid addresses in the explore input.

Describe the solution you'd like

Describe alternatives you've considered

Additional context

@Bitcoinera
Copy link
Contributor

Bitcoinera commented Jan 21, 2020

Actually this is already working xD

I think we just didn't notice... 🤷‍♀️

I guess we will need to refactor a couple of things

@faboweb
Copy link
Collaborator Author

faboweb commented Jan 21, 2020

But this is not used in the FE. We are hardcoding network to prefix lookup rn.

@Bitcoinera
Copy link
Contributor

Bitcoinera commented Jan 22, 2020

But this is not used in the FE. We are hardcoding network to prefix lookup rn.

Exactly. Today I am making a PR to refactor this

EDIT: I just saw you already did it xD

@jbibla
Copy link
Collaborator

jbibla commented Jan 22, 2020

this is done already?

@Bitcoinera
Copy link
Contributor

this is done already?

Yes, we just need to merge it. It is here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants