Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve error log when attempting to relay redundant packets #1135

Closed
jtieri opened this issue Mar 22, 2023 · 0 comments · Fixed by #1214
Closed

improve error log when attempting to relay redundant packets #1135

jtieri opened this issue Mar 22, 2023 · 0 comments · Fixed by #1214
Assignees
Labels
T: Enhancement TYPE: Enhancement

Comments

@jtieri
Copy link
Member

jtieri commented Mar 22, 2023

The error logged when the relayer attempts to relay packets already handled by another relayer is very verbose and for an inexperienced operator this can look like something that requires intervention when in reality it is a normal situation to observe.
We should clean this up and make it clear that there is nothing to be done.

ex:

2023-03-22T16:43:02.481620Z     error   Failed sending cosmos transaction       {"provider_type": "cosmos", "chain_id": "osmosis", "msg_types": ["/ibc.core.client.v1.MsgUpdateClient", "/ibc.core.channel.v1.MsgAcknowledgement"], "error": "packet messages are redundant", "errorVerbose": "packet messages are redundant\ncosmossdk.io/errors.Wrap\n\t/home/laurens/go/pkg/mod/cosmossdk.io/errors@v1.0.0-beta.7/errors.go:187\ncosmossdk.io/errors.ABCIError\n\t/home/laurens/go/pkg/mod/cosmossdk.io/errors@v1.0.0-beta.7/errors.go:75\ngit.luolix.top/cosmos/relayer/v2/relayer/chains/cosmos.(*CosmosProvider).sdkError\n\t/home/laurens/quasar-finance/relayer/relayer/chains/cosmos/tx.go:170\ngit.luolix.top/cosmos/relayer/v2/relayer/chains/cosmos.(*CosmosProvider).broadcastTx\n\t/home/laurens/quasar-finance/relayer/relayer/chains/cosmos/tx.go:206\ngit.luolix.top/cosmos/relayer/v2/relayer/chains/cosmos.(*CosmosProvider).SendMessagesToMempool\n\t/home/laurens/quasar-finance/relayer/relayer/chains/cosmos/tx.go:152\ngit.luolix.top/cosmos/relayer/v2/relayer/processor.(*messageProcessor).sendSingleMessage\n\t/home/laurens/quasar-finance/relayer/relayer/processor/message_processor.go:439\nruntime.goexit\n\t/home/laurens/.go/src/runtime/asm_amd64.s:1594"}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T: Enhancement TYPE: Enhancement
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants