Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rework animations #3

Open
octfx opened this issue Dec 6, 2019 · 1 comment
Open

Rework animations #3

octfx opened this issue Dec 6, 2019 · 1 comment
Labels
enhancement New feature or request performance
Milestone
1.1.0

Comments

@octfx
Copy link
Member

octfx commented Dec 6, 2019

For every animation a new animation object is created. This causes a lot of initialization overhead for every animated state.
Animations should be initialized only once and refactored to be re-usable.
@octfx octfx added enhancement New feature or request performance labels Dec 6, 2019
@octfx octfx mentioned this issue Dec 9, 2019
Merged
@octfx octfx added this to the 1.1.0 milestone Dec 10, 2019
@octfx
Copy link
Member Author

octfx commented Dec 10, 2019

Pull request #4 removes all reactive components from the animation class. This speeds up the object initialization a lot.
Animation caching should still be implemented.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request performance
Projects
None yet
Milestone
1.1.0
Development

No branches or pull requests
1 participant
@octfx