Fix baseurl not passed to app.js
#1955
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cotes2020
force-pushed
the
fix-pwa-baseurl
branch
from
cf07492
to
a142a8f
Compare
aishukander
added a commit
to aishukander/aishukander.github.io
that referenced
this pull request
Sep 27, 2024
Update the share.yml file to add a new platform for Reddit sharing. Also, modify the sidebar.html file to change the site title element to a clickable link. Closes cotes2020#1955
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description
In #1734, the expected behavior of reading options from
_config.ymlinapp.jsis limited to the site configuration state at the time of theapp.jsRollup build. This means it cannot read user-defined options, such asbaseurl(#1909).Therefore, this has been modified to pass the baseurl to app.js via the URL to achieve the intended design.
Additional context
v7.0.0~v7.1.0