Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use prettier for project? #214

Closed
kennethnym opened this issue Oct 21, 2019 · 5 comments · Fixed by #217
Closed

Use prettier for project? #214

kennethnym opened this issue Oct 21, 2019 · 5 comments · Fixed by #217

Comments

@kennethnym
Copy link
Collaborator

Right now prettier isn't used by the project. Would be great if it is.

@couds
Copy link
Owner

couds commented Oct 25, 2019

Hi can you tell me the benefits of adding this on the top of the eslint?

@kennethnym
Copy link
Collaborator Author

It is an automatic, opinionated code formatter so you dont have to manually format the code yourself. It also enforces consistent code style which i think is important. also its supre convenient to not having to worry about formatting since it does all the work..

@couds
Copy link
Owner

couds commented Oct 26, 2019

But what is does in this PR that eslint . —fix’ does not?

@kennethnym
Copy link
Collaborator Author

prettier/prettier-eslint#101
I think this should answer your question :)

@RobJacobson
Copy link

Seconded. Prettier enforces visual styles like indentation and object formatting, rather than substantive styles like eslint. It's more and more common across the web. If you use Prettier, then your code will look more similar with other people's code.

Prettier is highly opinionated and it enforces those opinions. One of the best statements I've read is that "I hate how Prettier reformats my own code, but I love how it fixes/cleans up my coworkers' code." It makes all of the code look consistent, regardless of who wrote it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants