Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Empty response with proxy gzip response #142

Closed
malud opened this issue Mar 12, 2021 · 1 comment · Fixed by #145
Closed

Empty response with proxy gzip response #142

malud opened this issue Mar 12, 2021 · 1 comment · Fixed by #145
Labels
bug Something isn't working

Comments

@malud
Copy link
Collaborator

malud commented Mar 12, 2021

If the upstream backend answers with a gzip body the reverseproxy component throws a panic panic: net/http: abort Handler which is related to an error during body copy (client went away or writer closed).

  1. Empty response because the server crashed.
  2. Seems to be a bug in combination with our response writer wrapper und a gzip writer (close call?)

Couper Version: 0.6

Configuration:

server "zipzip" {
  endpoint "/**" {
    proxy {
      backend {
        path = "/en/"
        set_request_headers = {
          Accept-Encoding: "gzip"
        }
        origin = "https://wao.io/"
      }
    }
  }
}
@malud malud added bug Something isn't working regression An already working behaviour is broken labels Mar 12, 2021
@malud malud removed the regression An already working behaviour is broken label Mar 13, 2021
@malud
Copy link
Collaborator Author

malud commented Mar 13, 2021

So in this case the upstream server did not send the gzip footer which results in a panic during body copy.

The missing recover() for our roundtrip routines leads to an exit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant