Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

auto reload config when config file changes #24

Closed
frederik-b opened this issue Sep 18, 2020 · 1 comment · Fixed by #185
Closed

auto reload config when config file changes #24

frederik-b opened this issue Sep 18, 2020 · 1 comment · Fixed by #185
Labels
enhancement New feature or request k8s Kubernetes specific topics theme/config
Milestone

Comments

@frederik-b
Copy link

When used in kubernetes with a config file mounted from a config map,
it would be best to have cooper autodetect changes in a/the config file and auto reload it.

Also: Make a boot param to enable/disable this feature.

@malud malud added enhancement New feature or request k8s Kubernetes specific topics labels Sep 18, 2020
@filex
Copy link
Contributor

filex commented Mar 30, 2021

Yes, we should implement a config reloader!

For me, the main use-case is the local development environment. When I am working in my Couper config it is cumbersome to always restart the docker container (or compose service).

I see the kube use-case as more complicated. If you have multiple replicas of your gateway running, you wouldn't want them to restart at the same time. We would have to implement a very graceful reconfiguration process that doesn't loose any requests.

For local dev setup that isn't so important - allowing for a much simpler implementation for now.

@malud malud added this to the 1.0 milestone Apr 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request k8s Kubernetes specific topics theme/config
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants