New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sequence #405

Merged

johakoch merged 68 commits into master from request-sequence

Dec 21, 2021

Collaborator

malud commented Dec 3, 2021 •

edited

Loading

Determine a possible sequence of roundtrips due to variable references.

Additionally there are some internal improvements access the backend response variables for all layers like endpoint, custom logs and error handling.

Reviewer checklist

Read PR description: a summary about the changes is required
Changelog updated
Documentation: docs/{Reference, Cli, ...}, Docker and cli help/usage
Pulled branch, manually tested
Verified requirements are met
Reviewed the code
Reviewed the related tests

johakoch reviewed

View reviewed changes

server/http_endpoints_test.go Outdated Show resolved Hide resolved

johakoch reviewed

View reviewed changes

server/http_endpoints_test.go Outdated Show resolved Hide resolved

malud commented

View reviewed changes

server/http_endpoints_test.go Show resolved Hide resolved

johakoch reviewed

View reviewed changes

config/runtime/endpoint.go Outdated Show resolved Hide resolved

johakoch reviewed

View reviewed changes

docs/REFERENCE.md Outdated Show resolved Hide resolved

johakoch reviewed

View reviewed changes

docs/REFERENCE.md Outdated Show resolved Hide resolved

johakoch reviewed

View reviewed changes

handler/transport/backend_test.go Outdated Show resolved Hide resolved

malud marked this pull request as ready for review

December 14, 2021 08:48

malud force-pushed the request-sequence branch from b20760f to 3a361d5 Compare

December 14, 2021 12:49

johakoch reviewed

View reviewed changes

config/runtime/server.go Outdated Show resolved Hide resolved

johakoch reviewed

View reviewed changes

config/runtime/server.go Outdated Show resolved Hide resolved

Marcel Ludwig added 19 commits

December 21, 2021 12:05


          Add config based static req sequence

4bf80af


          Refactor endpoint produce channel close handling

346064f


          add proxies to seq

e5ef861


          Fix collecting proxy deps


          Support sequences in parallel

f8d24c6


          Fixup sequence self-ref

6c01d1c


          Fixup test due to endpoint result channel refactoring

a75e6a4


          tests using same client settings

1b9fdb4


          Fix passed produce context; reduced req ptr value overrides

47919ab


          Refactor: reduce loop complexity

aab3d91


          add test for a simple sequence

99bb9c3


          more sequence test-cases

d4a840d


          Refactor configload files: ordered methods by context

7f4f451


          remove obsolete methods

dcdda57


          refactor sequence interface to own file


          Fixup collecting attr expr for nested blocks

964d026


          Add sequence cancel and timeout test

d98811e


          Fixup missing bufferOptions for sequence context

3bcbcab


          Add body value to proxy sequence test

5e67d49

Marcel Ludwig and others added 17 commits

December 21, 2021 12:06


          moved log level test file to combined log folder

a390de9


          Test custom logs within endpoint error handler

8480df0


          fix heading levels

38ac7ab


          separate tables for groups of error types

96f4a03


          Refactor mergedBody type to own package

4e20702

and variadic


          Refactor mustBuffer and fixed nested handling

4acba6f


          Add endpoint error_handler test with body variable access

dfab600


          Fixup backend roundtrip test; set at least outreq var

9f73a3b


          Fix log fields order, ac protected block first

7c269cc


          Refactor accessing backend related hcl variables via syncMap

0ed2d3a


          Refactor several methods to use the hclEvalcontext as argument

6cf2897


          Fixup handling type assertions, default type value instead of panic

7d88ce5


          Fixup removed default roundtrip name

f702533


          Fixup backend context handling

947c0de


          Fix test template format

fe71e99


          parse backend response body just once

818d4ad


          body naming and access via remain

d370864

malud force-pushed the request-sequence branch from ae61a39 to d370864 Compare

December 21, 2021 11:07

johakoch requested changes

View reviewed changes

docs/ERRORS.md Outdated Show resolved Hide resolved

config/configload/load.go Outdated Show resolved Hide resolved

Johannes Koch and others added 4 commits

December 21, 2021 13:35


          no format given

fa7d5ac


          fixed order of imports

c891778


          Add documentation and changelog entry

54fe6e2


          toc links

fc36562

johakoch previously approved these changes

View reviewed changes


          added changelog entry for unexpected_status error type

eac1671

johakoch dismissed their stale review via

eac1671

December 21, 2021 13:06


          Update docs and changelog for unexpected_status

36a7a93

johakoch approved these changes

View reviewed changes

johakoch merged commit bc08970 into master

johakoch deleted the request-sequence branch

December 21, 2021 13:17

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet