Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix empty strings with default func #408

Merged
merged 7 commits into from
Dec 17, 2021
Merged

Fix empty strings with default func #408

merged 7 commits into from
Dec 17, 2021

Conversation

malud
Copy link
Collaborator

@malud malud commented Dec 16, 2021

Fix handling empty strings as unset value if the fallback is a string type too.

Reviewer checklist
  • Read PR description: a summary about the changes is required
  • Changelog updated
  • Documentation: docs/{Reference, Cli, ...}, Docker and cli help/usage
  • Pulled branch, manually tested
  • Verified requirements are met
  • Reviewed the code
  • Reviewed the related tests

afflerbach
afflerbach previously approved these changes Dec 16, 2021
View reviewed changes
@malud malud merged commit 2d25b37 into master Dec 17, 2021
@malud malud deleted the fix-default-func-string branch December 17, 2021 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alex-schneider alex-schneider alex-schneider approved these changes

@afflerbach afflerbach afflerbach left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@malud @afflerbach @alex-schneider