Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

settings from configuration file gets ignored #61

Closed
malud opened this issue Nov 10, 2020 · 1 comment · Fixed by #92
Closed

settings from configuration file gets ignored #61

malud opened this issue Nov 10, 2020 · 1 comment · Fixed by #92
Assignees
@malud
Labels
bug Something isn't working good first issue Good for newcomers theme/config
Milestone
0.5

Comments

@malud
Copy link
Collaborator

malud commented Nov 10, 2020

Except the default_port option all other possible attributes from the settings block needs to be merged with the default http configuration (default -> flag -> env).
@malud malud added bug Something isn't working good first issue Good for newcomers theme/config labels Nov 10, 2020
@malud malud added this to the 0.3 milestone Dec 2, 2020
@malud malud modified the milestones: 0.3, 0.4 Dec 15, 2020
@malud malud self-assigned this Jan 14, 2021
@filex
Copy link
Contributor

filex commented Jan 14, 2021

still, the -log-format json setting is only available as flag anymore. both env (COUPER_LOG_FORMAT) and settings { … } are ignored.

we have ENV COUPER_LOG_FORMAT=json in our Dockerfile. since the 0.4 release, this does not work anymore. because of this, the default behaviour of the docker container has changed. it logs unstructured text instead of json now.

@malud malud mentioned this issue Jan 14, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@malud malud

Labels
bug Something isn't working good first issue Good for newcomers theme/config
Projects
None yet
Milestone
0.5
Development

Successfully merging a pull request may close this issue.

Fix log_format configuration coupergateway/couper
2 participants
@filex @malud