Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OIDC: userinfo_endpoint is RECOMMENDED, but not REQUIRED #708

Closed
johakoch opened this issue Feb 8, 2023 · 2 comments · Fixed by #709
Closed

OIDC: userinfo_endpoint is RECOMMENDED, but not REQUIRED #708

johakoch opened this issue Feb 8, 2023 · 2 comments · Fixed by #709
Milestone

Comments

@johakoch
Copy link
Collaborator

johakoch commented Feb 8, 2023

According to https://openid.net/specs/openid-connect-discovery-1_0.html#ProviderMetadata, the userinfo_endpoint is RECOMMENDED, but not REQUIRED.

So, if the openid-configuration, for whatever reason, does not include a userinfo_endpoint, no userinfo should be requested.
Accordingly,

  • the sub claim from the id token cannot be verified against the sub property from the userinfo response,
  • no userinfo is stored in request.context.<oidc_name>.
@johakoch johakoch changed the title OIDC: userinfo_endpoint is RECOMMENDES, but not REQUIRED OIDC: userinfo_endpoint is RECOMMENDED, but not REQUIRED Feb 8, 2023
@johakoch johakoch linked a pull request Feb 8, 2023 that will close this issue
@johakoch johakoch added this to the 1.12.1 milestone Feb 8, 2023
@johakoch
Copy link
Collaborator Author

johakoch commented Feb 9, 2023

Are issues that are on a milestone not automatically closed if the linked PR is merged?

@malud
Copy link
Collaborator

malud commented Feb 13, 2023

Works, comfirmed with an Azure B2C application without an userinfo_endpoint within the configuration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants