Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to close with CTRL+C, when running directly #64

Closed
msmyers opened this issue Dec 13, 2019 · 4 comments
Closed

Unable to close with CTRL+C, when running directly #64

msmyers opened this issue Dec 13, 2019 · 4 comments
Assignees
Labels

Comments

@msmyers
Copy link

msmyers commented Dec 13, 2019

While testing out the script (amazing work, btw), I typed slacktee.sh in my terminal.

It gave me a warning about "using the URL is deprecated, please use token" and then it hung, with CTRL+C not aborting. I was forced to restart my terminal session.

Thoughts?

Running echo "hey" | slacktee.sh worked

@Chikashi-Kato
Copy link
Member

Thank you for trying slacktee and reporting the issue, @msmyers!
I will test it out and get back to you.

@Chikashi-Kato
Copy link
Member

Chikashi-Kato commented Dec 16, 2019

I confirmed the behavior. slacktee.sh doesn't handle CTRL+C. I'm adding a signal handler to slacktee.sh.

BTW, we can still finish slacktee.sh by sending End-of-Transmission with CTRL+D, but in this case, all of the input characters are sent to slack. Therefore, I believe supporting CTRL+C for abort sending message is useful.

@Chikashi-Kato Chikashi-Kato self-assigned this Dec 16, 2019
@Chikashi-Kato
Copy link
Member

Chikashi-Kato commented Dec 16, 2019

BTW, "using the URL is deprecated, please use token" is just a deprecation warning introduced at v1.4.0 and it's not related with this issue.
If you want to suppress it, please use token instead of webhook.

@Chikashi-Kato
Copy link
Member

@msmyers This has been fixed with v1.4.2. Thanks again for reporting this issue!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants