Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Latest NuGet package no longer works #359

Closed
ThinkAboutGitHub opened this issue Mar 5, 2019 · 8 comments
Closed

Latest NuGet package no longer works #359

ThinkAboutGitHub opened this issue Mar 5, 2019 · 8 comments

Comments

@ThinkAboutGitHub
Copy link

Hi there
we upgraded our coverlet NuGet package from 2.5.1 to 2.6, and now when we collect code coverage we face the following error on our previously working build:
2019-03-05T03:32:00.3145123Z /root/.nuget/packages/coverlet.msbuild/2.6.0/build/netstandard2.0/coverlet.msbuild.targets(35,5): error : One or more errors occurred. (Could not find file '/tmp/xunit.runner.visualstudio.dotnetcore.testadapter_4b89fa9e-938a-4b8b-9462-1be5220ac0f4.pdb'.) (Could not find file '/tmp/xunit.runner.visualstudio.dotnetcore.testadapter_4b89fa9e-938a-4b8b-9462-1be5220ac0f4.pdb'.) (Could not find file '/tmp/xunit.runner.visualstudio.dotnetcore.testadapter_4b89fa9e-938a-4b8b-9462-1be5220ac0f4.pdb'.) (Could not find file '/tmp/xunit.runner.visualstudio.dotnetcore.testadapter_4b89fa9e-938a-4b8b-9462-1be5220ac0f4.pdb'.) (Could not find file '/tmp/xunit.runner.visualstudio.dotnetcore.testadapter_4b89fa9e-938a-4b8b-9462-1be5220ac0f4.pdb'.) (Could not find file '/tmp/xunit.runner.visualstudio.dotnetcore.testadapter_4b89fa9e-938a-4b8b-9462-1be5220ac0f4.pdb'.) (Could not find file '/tmp/xunit.runner.visualstudio.dotnetcore.testadapter_4b89fa9e-938a-4b8b-9462-1be5220ac0f4.pdb'.) (Could not find file '/tmp/xunit.runner.visualstudio.dotnetcore.testadapter_4b89fa9e-938a-4b8b-9462-1be5220ac0f4.pdb'.) (Could not find file '/tmp/xunit.runner.visualstudio.dotnetcore.testadapter_4b89fa9e-938a-4b8b-9462-1be5220ac0f4.pdb'.) (Could not find file '/tmp/xunit.runner.visualstudio.dotnetcore.testadapter_4b89fa9e-938a-4b8b-9462-1be5220ac0f4.pdb'.) [/app/[redacted].UnitTests/[redacted].UnitTests.csproj]
2019-03-05T03:32:00.3171472Z /root/.nuget/packages/coverlet.msbuild/2.6.0/build/netstandard2.0/coverlet.msbuild.targets(35,5): error : at Coverlet.Core.RetryHelper.Do[T](Func1 action, Func1 backoffStrategy, Int32 maxAttemptCount) in /Users/toni/Workspace/coverlet/src/coverlet.core/Helpers/RetryHelper.cs:line 58 [/app/[redacted].UnitTests/[redacted].UnitTests.csproj]
2019-03-05T03:32:00.3183781Z /root/.nuget/packages/coverlet.msbuild/2.6.0/build/netstandard2.0/coverlet.msbuild.targets(35,5): error : at Coverlet.Core.RetryHelper.Retry(Action action, Func`1 backoffStrategy, Int32 maxAttemptCount) in /Users/toni/Workspace/coverlet/src/coverlet.core/Helpers/RetryHelper.cs:line 27 [/app/[redacted].UnitTests/[redacted].UnitTests.csproj]
2019-03-05T03:32:00.3195634Z /root/.nuget/packages/coverlet.msbuild/2.6.0/build/netstandard2.0/coverlet.msbuild.targets(35,5): error : at Coverlet.Core.Coverage.GetCoverageResult() in /Users/toni/Workspace/coverlet/src/coverlet.core/Coverage.cs:line 108 [/app/[redacted].UnitTests/[redacted].UnitTests.csproj]
2019-03-05T03:32:00.3208948Z /root/.nuget/packages/coverlet.msbuild/2.6.0/build/netstandard2.0/coverlet.msbuild.targets(35,5): error : at Coverlet.MSbuild.Tasks.CoverageResultTask.Execute() in /Users/toni/Workspace/coverlet/src/coverlet.msbuild.tasks/CoverageResultTask.cs:line 67 [/app/[redacted].UnitTests/[redacted].UnitTests.csproj]
2019-03-05T03:32:00.5604147Z The command '/bin/sh -c dotnet test --results-directory /testresults --logger "trx;LogFileName=test_results.xml" /p:CollectCoverage=true /p:CoverletOutputFormat=cobertura /p:CoverletOutput=/testresults/coverage/ ./[redacted].UnitTests/[redacted].UnitTests.csproj' returned a non-zero code: 1
2019-03-05T03:32:00.8160815Z ##[debug]$LASTEXITCODE: 1

@tomap
Copy link

tomap commented Mar 5, 2019

I had the same issue.
I solved it using /p:Exclude="[xunit*]*"

@default-writer
Copy link

default-writer commented Mar 5, 2019

If you assembly requres and references NuGet packages, it is still not recoverable, @tomap @tonerdo @ThinkAboutGitHub

see my logs

switched to 2.5.1: log1.txt
switched to 2.6.0: log2.txt
switched to 2.5.1: log3.txt

Finally, you have to skip all NuGet packages at all:

https://ci.appveyor.com/project/hack2root/build/builds/22850801

/p:Include="[Build]*" -v:n, resulting in

     1>Project "C:\projects\build\Build.Tests\Build.Tests.csproj" on node 1 (VSTest target(s)).
     1>InstrumentModulesNoBuild:
         [coverlet] Included module filter '[Build]*'
         [coverlet] Excluded module: 'C:\projects\build\Build.Tests\bin\Release\netcoreapp3.0\Build.Abstractions.dll'
         [coverlet] Instrumented module: 'C:\projects\build\Build.Tests\bin\Release\netcoreapp3.0\Build.dll'
         [coverlet] Excluded module: 'C:\projects\build\Build.Tests\bin\Release\netcoreapp3.0\Build.Tests.dll'
         [coverlet] Excluded module: 'C:\projects\build\Build.Tests\bin\Release\netcoreapp3.0\Microsoft.DotNet.PlatformAbstractions.dll'
         [coverlet] Excluded module: 'C:\projects\build\Build.Tests\bin\Release\netcoreapp3.0\Microsoft.Extensions.DependencyModel.dll'
         [coverlet] Excluded module: 'C:\projects\build\Build.Tests\bin\Release\netcoreapp3.0\Microsoft.TestPlatform.CommunicationUtilities.dll'
         [coverlet] Excluded module: 'C:\projects\build\Build.Tests\bin\Release\netcoreapp3.0\Microsoft.TestPlatform.CoreUtilities.dll'
         [coverlet] Excluded module: 'C:\projects\build\Build.Tests\bin\Release\netcoreapp3.0\Microsoft.TestPlatform.CrossPlatEngine.dll'
         [coverlet] Excluded module: 'C:\projects\build\Build.Tests\bin\Release\netcoreapp3.0\Microsoft.TestPlatform.PlatformAbstractions.dll'
         [coverlet] Excluded module: 'C:\projects\build\Build.Tests\bin\Release\netcoreapp3.0\Microsoft.TestPlatform.Utilities.dll'
         [coverlet] Excluded module: 'C:\projects\build\Build.Tests\bin\Release\netcoreapp3.0\Microsoft.VisualStudio.CodeCoverage.Shim.dll'
         [coverlet] Excluded module: 'C:\projects\build\Build.Tests\bin\Release\netcoreapp3.0\Microsoft.VisualStudio.TestPlatform.Common.dll'
         [coverlet] Excluded module: 'C:\projects\build\Build.Tests\bin\Release\netcoreapp3.0\Microsoft.VisualStudio.TestPlatform.ObjectModel.dll'
         [coverlet] Excluded module: 'C:\projects\build\Build.Tests\bin\Release\netcoreapp3.0\Newtonsoft.Json.dll'
         [coverlet] Excluded module: 'C:\projects\build\Build.Tests\bin\Release\netcoreapp3.0\System.Xml.XPath.XmlDocument.dll'
         [coverlet] Excluded module: 'C:\projects\build\Build.Tests\bin\Release\netcoreapp3.0\testhost.dll'
         [coverlet] Excluded module: 'C:\projects\build\Build.Tests\bin\Release\netcoreapp3.0\xunit.abstractions.dll'
         [coverlet] Excluded module: 'C:\projects\build\Build.Tests\bin\Release\netcoreapp3.0\xunit.assert.dll'
         [coverlet] Excluded module: 'C:\projects\build\Build.Tests\bin\Release\netcoreapp3.0\xunit.core.dll'
         [coverlet] Excluded module: 'C:\projects\build\Build.Tests\bin\Release\netcoreapp3.0\xunit.execution.dotnet.dll'
         [coverlet] Excluded module: 'C:\projects\build\Build.Tests\bin\Release\netcoreapp3.0\xunit.runner.reporters.netcoreapp10.dll'
         [coverlet] Excluded module: 'C:\projects\build\Build.Tests\bin\Release\netcoreapp3.0\xunit.runner.utility.netcoreapp10.dll'
         [coverlet] Excluded module: 'C:\projects\build\Build.Tests\bin\Release\netcoreapp3.0\xunit.runner.visualstudio.dotnetcore.testadapter.dll'

@default-writer
Copy link

I had the same issue.
I solved it using /p:Exclude="[xunit*]*"

or you can /p:Include, everything else will automatically be excluded!

@jherby2k
Copy link
Contributor

jherby2k commented Mar 12, 2019

Yeah, this is the second minor version release that has blown up my CI. I'm already excluding xunit, but its reporting errors and returning a 1 exit code because it can't find a PDB file for System.Threading.Tasks.Dataflow.dll. No effing kidding! That's because its not my code.

@sharwell
Copy link
Contributor

I'm starting to think this is caused by #362

@MarcoRossignoli
Copy link
Collaborator

@jherby2k do you have a stack trace to show?

adamconnelly added a commit to adamconnelly/ConcurrencyLimits.Net that referenced this issue Mar 25, 2019
- Added code coverage using Coverlet.
- Removed deliberate warning from OperationInfo.

**NOTE:** I deliberately added version 2.5.1 of Coverlet because the latest version seems to be broken by coverlet-coverage/coverlet#359.
@richlander
Copy link

Just added coverlet to a new project. Running into the same problem. Downgraded to v2.5.1 and everything works.

What I see:

C:\git\sudoku-solver\src\sudoku-tests>dotnet test /p:CollectCoverage=true
Test run for C:\git\sudoku-solver\src\sudoku-tests\bin\Debug\netcoreapp3.0\sudoku-tests.dll(.NETCoreApp,Version=v3.0)
Microsoft (R) Test Execution Command Line Tool Version 16.0.0-preview-20190124-02
Copyright (c) Microsoft Corporation.  All rights reserved.

Starting test execution, please wait...

Total tests: 3. Passed: 3. Failed: 0. Skipped: 0.
Test Run Successful.
Test execution time: 1.3952 Seconds

Calculating coverage result...
C:\Users\rlander\.nuget\packages\coverlet.msbuild\2.6.0\build\netstandard2.0\coverlet.msbuild.targets(35,5): error : Unable to read beyond the end of the stream. [C:\git\sudoku-solver\src\sudoku-tests\sudoku-tests.csproj]
C:\Users\rlander\.nuget\packages\coverlet.msbuild\2.6.0\build\netstandard2.0\coverlet.msbuild.targets(35,5): error :    at System.IO.BinaryReader.InternalRead(Int32 numBytes) [C:\git\sudoku-solver\src\sudoku-tests\sudoku-tests.csproj]
C:\Users\rlander\.nuget\packages\coverlet.msbuild\2.6.0\build\netstandard2.0\coverlet.msbuild.targets(35,5): error :    at System.IO.BinaryReader.ReadInt32() [C:\git\sudoku-solver\src\sudoku-tests\sudoku-tests.csproj]
C:\Users\rlander\.nuget\packages\coverlet.msbuild\2.6.0\build\netstandard2.0\coverlet.msbuild.targets(35,5): error :    at Coverlet.Core.Coverage.CalculateCoverage() in /Users/toni/Workspace/coverlet/src/coverlet.core/Coverage.cs:line 227 [C:\git\sudoku-solver\src\sudoku-tests\sudoku-tests.csproj]
C:\Users\rlander\.nuget\packages\coverlet.msbuild\2.6.0\build\netstandard2.0\coverlet.msbuild.targets(35,5): error :    at Coverlet.Core.Coverage.GetCoverageResult() in /Users/toni/Workspace/coverlet/src/coverlet.core/Coverage.cs:line 107 [C:\git\sudoku-solver\src\sudoku-tests\sudoku-tests.csproj]
C:\Users\rlander\.nuget\packages\coverlet.msbuild\2.6.0\build\netstandard2.0\coverlet.msbuild.targets(35,5): error :    at Coverlet.MSbuild.Tasks.CoverageResultTask.Execute() in /Users/toni/Workspace/coverlet/src/coverlet.msbuild.tasks/CoverageResultTask.cs:line 69 [C:\git\sudoku-solver\src\sudoku-tests\sudoku-tests.csproj]

@MarcoRossignoli
Copy link
Collaborator

MarcoRossignoli commented Mar 29, 2019

@richlander your issue seems related to #210 there is a pending PR #329
pdf issue seems related to embedded pdb #372 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants