Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating System.Reflection.Metadata version #392

Merged

Conversation

vagisha-nidhi
Copy link
Contributor

Issue related #391
Updating version of System.Reflection.Metadata

Copy link
Collaborator

@MarcoRossignoli MarcoRossignoli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM to unblock user, CI issue are unrelated(pdb know issue), already warned on possible future breaking changes.

@MarcoRossignoli
Copy link
Collaborator

/cc @tonerdo

@codecov
Copy link

codecov bot commented May 8, 2019

Codecov Report

Merging #392 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #392   +/-   ##
=======================================
  Coverage   87.13%   87.13%           
=======================================
  Files          16       16           
  Lines        2106     2106           
=======================================
  Hits         1835     1835           
  Misses        271      271

@codecov
Copy link

codecov bot commented May 8, 2019

Codecov Report

Merging #392 into master will decrease coverage by 0.17%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #392      +/-   ##
==========================================
- Coverage   87.13%   86.96%   -0.18%     
==========================================
  Files          16       16              
  Lines        2106     2178      +72     
==========================================
+ Hits         1835     1894      +59     
- Misses        271      284      +13

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants