Fix 'Failed to resolve assembly' cecil issue #625
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarcoRossignoli
commented
Nov 28, 2019
| private readonly string _modulePath; | ||
| // this is lazy because we cannot create AspNetCoreSharedFrameworkResolver if not on .NET Core runtime, | ||
| // runtime folders are different | ||
| private readonly Lazy<CompositeCompilationAssemblyResolver> _compositeResolver = new Lazy<CompositeCompilationAssemblyResolver>(() => new CompositeCompilationAssemblyResolver(new ICompilationAssemblyResolver[] |
There was a problem hiding this comment.
Here build up composite resolver...so we check on defaults and also on aspnetcore shared folders at the end
MarcoRossignoli
commented
Nov 28, 2019
|
|
||
| using DependencyContextJsonReader contextJsonReader = new DependencyContextJsonReader(); | ||
| Dictionary<string, Lazy<AssemblyDefinition>> libraries = new Dictionary<string, Lazy<AssemblyDefinition>>(); | ||
| foreach (string fileName in Directory.GetFiles(Path.GetDirectoryName(_modulePath), "*.deps.json")) |
There was a problem hiding this comment.
search and load all deps files and try to resolve
MarcoRossignoli
commented
Nov 28, 2019
| } | ||
| catch (AssemblyResolutionException) | ||
| { | ||
| if (IsDotNetCore()) |
There was a problem hiding this comment.
try manual resolving in case of .net app
MarcoRossignoli
commented
Nov 28, 2019
| } | ||
| } | ||
|
|
||
| internal class AspNetCoreSharedFrameworkResolver : ICompilationAssemblyResolver |
There was a problem hiding this comment.
asp.net core shared framework resolver, search inside folders
MarcoRossignoli
commented
Nov 28, 2019
| /// correct forwards. | ||
| /// Check compares 'assembly name' and 'public key token', because versions could differ between runtimes. | ||
| /// </summary> | ||
| internal class NetstandardAwareAssemblyResolver : DefaultAssemblyResolver |
There was a problem hiding this comment.
Moved in new own file
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Merged
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #560 and improve scenario where we have to use
/p:CopyLocalLockFileAssemblies=trueIn case of load issue we get
If we add
<PreserveCompilationContext>custom load seem to work.thank's @rpatrick00 for the repro.
I ask to some guys that helped with solution to check if could work @livarcocc @dasMulli @nguerrera @dsplaisted @elinor-fung and @jbevain from which I took some piece of code for resolver.
We need to check if we're on core because we support also .NET Framework.
cc: @tonerdo @petli