Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the normalization of seasonality factors #130

Merged
merged 1 commit into from
May 28, 2021
Merged

Conversation

janosg
Copy link
Contributor

@janosg janosg commented May 28, 2021

No description provided.

Copy link
Collaborator

@roecla roecla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Genius 🎉 Thanks for fixing it!

@codecov
Copy link

codecov bot commented May 28, 2021

Codecov Report

Merging #130 (cca14b8) into main (d745885) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #130   +/-   ##
=======================================
  Coverage   92.24%   92.24%           
=======================================
  Files          57       57           
  Lines        3290     3290           
=======================================
  Hits         3035     3035           
  Misses        255      255           
Flag Coverage Δ
end_to_end 55.37% <75.00%> (ø)
integration 56.93% <0.00%> (ø)
unit 64.98% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
tests/test_seasonality.py 100.00% <ø> (ø)
src/sid/seasonality.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d745885...cca14b8. Read the comment docs.

@roecla roecla merged commit 3e311ef into main May 28, 2021
@roecla roecla deleted the fix-seasonality branch May 28, 2021 10:19
@tobiasraabe tobiasraabe added this to the v0.0.9 milestone May 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants