Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Improvement of the print progress effect to show more information. Would it be possible to have the LED's closest to 25%, 50%, and 75% blink as the printing progress effect passes them? For example, if a print is 65% of the way done the 65% of the LED strip length is light up (just as it is coded now), but additionally the nearest LED to 25% and 50% would blink/pulse. From the strip you could then easily tell you are past 20, 50 or 75% printed. #115

Open
vinster8108 opened this issue Mar 1, 2021 · 3 comments
Labels
help wanted Community help wanted to solve this request, up for grabs for a PR request New feature or request up for grabs Issue/FR will not be worked on, open for a member of the community to take it on

Comments

@vinster8108
Copy link

Is your feature request related to a problem? Please describe.

Describe the solution you'd like

Why should this be implemented?

Additional context

@github-actions github-actions bot added needs review Yet to be reviewed request New feature or request labels Mar 1, 2021
@cp2004
Copy link
Owner

cp2004 commented Mar 3, 2021

I don't really understand the benefit of this feature - I have never seen a progress bar where part flashes as it is gone, it either animates as a whole or not at all.

What is the significance of knowing 25%, 50% or 75%? As far as I know, those numbers don't mean anything in relation to 3D print in progress, and the actual progress is a lot more useful for that.

@cp2004 cp2004 removed the needs review Yet to be reviewed label Mar 3, 2021
@vinster8108
Copy link
Author

Gotcha, I'm new to these addressable LEDs - this idea may be more trouble/coding then it's worth. The simple benefit is more information is displayed via the LEDs. With a vertical progress strip, I suppose it's pretty easy to estimate what your progress percentage is.
I think we are meaning the same thing with 3D print progress vs. actual progress. The start to finish progress.

I went a bit extra lol. I have 4 strips in parallel. My longest run is 89 LEDs and meets the second longest run in the middle of the top bar before spiraling at the top ring (pic attached). Progress indicators move up the sides simultaneously, meet in the middle of the cross bar and then fill out the ring. So at a glance, it isn't as easy for me to tell if my progress bar is half way done. A blinking LED at 25, 50 and 75% as the progress passes them would provide that information. I realize most may not find this addition overly beneficial.
WIN_20210305_21_04_13_Pro

@cp2004
Copy link
Owner

cp2004 commented Mar 6, 2021

Wow, that's some impressive setup... I like how neatly they fit in the channels of the extrusion.

Try the release candidate for 0.7.0 (#119) - there's 3 new progress effects, one that may be more beneficial is the one that moves from both ends, gradient would probably be a bit boring for that number of LEDs. I can't tell if it would work better or worse.

I would accept a PR that added a new progress effect for this. In the future we may also get per-segment control of the LEDs, it's one of my 'big ideas'. So you could just put the progress bar on the vertical sections.

@cp2004 cp2004 added the up for grabs Issue/FR will not be worked on, open for a member of the community to take it on label Mar 11, 2021
@github-actions github-actions bot added this to Needs triage in Feature Request triage Mar 11, 2021
@cp2004 cp2004 moved this from Needs triage to Accepting PRs in Feature Request triage Mar 18, 2021
@cp2004 cp2004 added the help wanted Community help wanted to solve this request, up for grabs for a PR label May 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Community help wanted to solve this request, up for grabs for a PR request New feature or request up for grabs Issue/FR will not be worked on, open for a member of the community to take it on
Projects
No open projects
Development

No branches or pull requests

2 participants