Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Request]: Custom color order for SK6812 compatible strips #221

Open
pawelsky opened this issue Mar 22, 2024 · 4 comments
Open

[Request]: Custom color order for SK6812 compatible strips #221

pawelsky opened this issue Mar 22, 2024 · 4 comments

Comments

@pawelsky
Copy link

pawelsky commented Mar 22, 2024

What would you like implemented?

I recently came across a WS2814/SK6812 compatible strip with (unusual?) WRGB color order, which I unfortunately cannot configure properly to use with this great plugin. The closest I can get is SK6812_STRIP_BRGW but the Blue and White are swapped.

While it probably does not make sense to add each possible color order to the dropdown menu it would be good to have an option to define a custom color order.

The easiest (but probably not most user friendly) way to do it would be to define a SK6812_STRIP_CUSTOM where use could define the custom shift mask in hex (the SK6812_SHIFT_WMASK in the underlying rpi_ws281x library's would probably have to be modified as well to correctly identify strips with separate white LEDs). More user friendly UI would of course be welcomed, but I can live with hexes hidden somewhere in the advanced section :)

Why should this be implemented?

To provide compatibility with more LED strip types

@cp2004
Copy link
Owner

cp2004 commented May 9, 2024

If the underlying library supports it, then I am happy for it to be in the plugin. I don't currently have time to do this or the hardware to test it with (I don't actually have SK6812 strips) - but if someone contributed it I would happily review & merge.

This plugin is long overdue an update, but I cannot put a timeframe on when I might be able to sink some time into it for now.

Apologies for the really delayed answer here, I completely missed this issue and only came looking because of the latest one that was opened.

@pawelsky
Copy link
Author

To my understanding the underlying library does not support it, but I have a code modification that would enable that. I'll propose it to them and let you know if they decide to implement it.

@cp2004
Copy link
Owner

cp2004 commented May 10, 2024

Great, thanks. Keep me updated, and I'll be happy to weigh in with opinions/support if it helps push it along.

@pawelsky
Copy link
Author

Raised an issue here: jgarff/rpi_ws281x#540

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants