-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[carp_communication_package 0.12.0] Using this package implies requesting restricted permissions #183
Comments
Actually I have just found the solution. The problem indeed occurs when merging manifest files. This means the illegal permissions can be omitted by specifying that they should not be merged from a lower level manifest. I suggest adding this information to the documentation of this package. Concretely, adding the following lines to the AndroidManifest prevents the restricted permissions from being added: <uses-permission android:name="android.permission.READ_CALL_LOG" tools:node="remove"/>
<uses-permission android:name="android.permission.READ_SMS" tools:node="remove"/>
<uses-permission android:name="android.permission.SEND_SMS" tools:node="remove"/>
<uses-permission android:name="android.permission.RECEIVE_SMS" tools:node="remove"/> |
Thanks for the input. But exactly - in which AndroidManifest should this be added? In the
? |
In the app you're building. This line of course indicates that these permissions from lower level manifests (i.e. from the SMS and call log plugin) should not be integrated. |
So - as I understand the above: There is no need to change the Right? |
That's correct. As long as developers are aware of this issue, it shouldn't raise any further problems. |
Added to the "Best Practice" page on the wiki: |
Motivation
We wish to publish our app, which uses various CARP package, to the Google Play Store. However, initially the app was rejected because we tried to collect SMS texts and call logs which Google considers to be a restricted group of permissions for which you need a valid reason to access those. Unfortunately, research is not in the list of exceptions. Hence, we would like to remove collection of SMS texts and call logs while still keeping collection of calendar information (all in the
carp_communication_package
).The problem
Upon adding
carp_communication_package 12.0.0
(or any later or earlier version for that matter), various restricted permissions such asandroid.permission.READ_SMS
andandroid.permissions.REAL_CALL_LOG
are automatically added because they reside in thecall_log
andsms
plugin that the package uses. As a consequence, the app is automatically rejected from the Play Store. Unfortunately, this problem persists even when removing call log and SMS texts from the sensing list, since these plugins are loaded immediately upon registeringcarp_communication_package
, regardless of whether the plugins will be used or not.Resolution
I'm not sure whether there could be any solution for this problem since it would almost mean disassembling the package itself. Perhaps there exists some code which prevents the permission from being requested or the plugin from being loaded? At least the documentation could use a warning for other users puzzling why problems occurs when trying to get an app published to the Play Store.
The text was updated successfully, but these errors were encountered: