Field host in struct OfxHost and String in enum PropertyValue can be leaked.

[labyrinth-ssr]

rustfx/src/rfx/propertyset.rs

Lines 11 to 18 in 8209089

	#[derive(Debug, Clone)]
	pub enum PropertyValue {
	Pointer(*const c_void),
	Integer(c_int),
	Double(c_double),
	String(*const c_char), // TODO : differenciate between host and plugin allocated strings
	Undefined,
	}

rustfx/src/rfx/propertyset.rs

Lines 117 to 122 in 8209089

	impl<'a> From<&'a str> for PropertyValue {
	fn from(value: &'a str) -> Self {
	let cstr = CString::new(value).unwrap();
	PropertyValue::String(cstr.into_raw())
	}
	}

The destructor won't release PropertyValue.String (on the heap since PropertyValue::String(c_str.to_owned().into_raw()) ), causing memory leak.

To free the field, probable fix is to implement drop for PropertyValue.

rustfx/src/suites/core.rs

Lines 116 to 121 in 8209089

	#[repr(C)]
	#[allow(non_snake_case)]
	pub struct OfxHost {
	pub host: OfxPropertySetHandle,
	pub fetchSuite: extern "C" fn(OfxPropertySetHandle, *const c_char, c_int) -> *mut c_void,
	}

rustfx/src/suites/core.rs

Lines 160 to 170 in 8209089

	impl OfxHost {
	pub fn new(properties: Box<OfxPropertySet>) -> Box<OfxHost> {
	let host_props = Box::into_raw(properties);
	trace!("properties for host set ptr is {:?}",
	host_props as *const _);
	Box::new(OfxHost {
	host: host_props as *mut libc::c_void,
	fetchSuite: fetch_suite,
	})
	}
	}

The destructor won't release OfxHost.host (on the heap since host_props = Box::into_raw(properties); ), causing memory leak.

Probable fix is to add release for host in drop for OfxHost.

rustfx/src/suites/core.rs

Lines 123 to 129 in 8209089

	#[cfg(debug)]
	impl Drop for OfxHost {
	fn drop( & mut self ) {
	println!("Dropping host");
	}
	}