Moving to C++17 support #725
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If you don't specify anything, C++17 is now default, so you wouldn't need to specifically call it out. But not bad to specify anyway |
SteveMacenski
approved these changes
Feb 15, 2022
|
Ah, maybe that's why our build broke when (I assume) most people's didn't (that is, because we were specifying C++14). |
|
Likely the case. I'm not sure when rolling will move to C++17, but from the TSC meetings it seems to be happening soon, so that's why I think that. I'm not 100% sure but the evidence seems to point to it. If you make this change and it doesn't fix the build, ping me and I'll take a look |
|
I have a PR in to the rosdistro to enable PR testing on this branch. Once that gets merged, I'll close/open this to kick it off again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trying to address https://build.ros2.org/job/Rbin_uJ64__robot_localization__ubuntu_jammy_amd64__binary/10/consoleFull