Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Feature Pitches (Happy to collaborate/contribute) #136

Open
bloniaszp opened this issue May 2, 2023 · 1 comment
Open

New Feature Pitches (Happy to collaborate/contribute) #136

bloniaszp opened this issue May 2, 2023 · 1 comment
Assignees

Comments

@bloniaszp
Copy link

Hi there,

I would love the chance to contribute several features to eegUtils. I have the following suggestions:

  1. Multitaper Spectral Analysis to give people parametric control over their spectral estimates
  2. Functional Connectivity capability: Coherency (complex valued), Coherence (modulus of coherency), and Global Coherence (frequency domain analog to PCA)
  3. Add a maximum likelihood based ICA (e.g., picard), in addition to FAST or infomax.

Otherwise, happy to make these as their own stand alone package if you feel their outside of your original scope.

Best regards,
Patrick

@craddm
Copy link
Owner

craddm commented Jun 7, 2023

Hi Patrick,

These are great ideas for features! Out of the three, I think particularly multitapers and additional ICA methods might fit nicely in the existing scope. I don't have a lot of time to work on the package these days (I'm not in the field any more) so won't get round to doing them myself, but those are things I'd have been interested in adding. Connectivity not so much, but only because I've never used it so am not familiar with it. Can totally see it as being within scope.

I was starting to come round to the idea of adding more features as external packages though, as the package was getting a little unwieldy - I had thought about refactoring it to a suite of packages rather than one monolithic package. But not likely that will happen now, either.

An external package for maximum likelihood based ICA might be good, as it feels like the kind of thing that might have applications beyond EEG data and that people might want to use without needing the rest of the package.

So, TL;DR - could fit either way, as standalone packages that we can interface with eegUtils, or as extensions to the existing codebase.

Cheers,
Matt

@craddm craddm self-assigned this Jun 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants