feat!: disable es6-like string interpolation ${} when compiling templates #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ates
This patch disables using ${} in the html templates. This is mostly
to avoid conflicts with the provided template that might use ${} in
inline javascript natively.
This patch also reverts the changes of #46.
lodash.template is now always called. this is useful for when you want
to use `process.env`.
Therefore, this change is breaking, as it removes ${}, but also always
calls lodash again.
If this ever will be a problem, we can also add a configuration option
to enable ${} manually again.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch disables using ${} in the html templates. This is mostly to avoid conflicts with the provided template that might use ${} in inline javascript natively.
This patch also reverts the changes of #46.
lodash.template is now always called. this is useful for when you want to use
process.env.Therefore, this change is breaking, as it removes ${}, but also always calls lodash again.
If this ever will be a problem, we can also add a configuration option to enable ${} manually again.
Fixes #60
Fixes #57
Fixes #48