Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.x]: Two-step verification set-up key has extra whitespace at the end when copied #15349

Closed
jamesmacwhite opened this issue Jul 13, 2024 · 2 comments
Labels

Comments

@jamesmacwhite
Copy link
Contributor

What happened?

Description

When being provided a seed for two-step verification to input into an authenticator app, if using the setup key, copying this either through the copy button or manually in the field itself, contains whitespace at the end of the value. While I think many authenticator apps will be able to handle this and remove the input, it may be worth ensuring there is no extra data in setup key value.

Steps to reproduce

  1. Start the two-step verification process
  2. Copy the setup key value using either the copy button or manually.

Expected behavior

No whitespace to be present, the last character of the setup key should be the end of the value.

Actual behavior

Whitespace is copied from the provided value.

Craft CMS version

5.2.6 Solo

PHP version

PHP 8.3

Operating system and version

No response

Database type and version

MySQL 8

Image driver and version

No response

Installed plugins and versions

No response

@brandonkelly
Copy link
Member

Fixed for the next release, thanks.

@jamesmacwhite
Copy link
Contributor Author

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants