Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.2.0]: LivePreview markup differs from Preview, missing styles #15640

Closed
superextinct opened this issue Sep 2, 2024 · 2 comments
Closed

[5.2.0]: LivePreview markup differs from Preview, missing styles #15640

superextinct opened this issue Sep 2, 2024 · 2 comments
Labels

Comments

@superextinct
Copy link

What happened?

Description

Solspace Calendar includes a live preview for their Event elements. When opening the preview, the editor panel is not scrollable and is missing some padding:

craft-calendar-test ddev site_admin_calendar_events_2_default

Live Preview gets initiated here through Craft.LivePreview.init, that's why I'm opening the issue here.

I believe this to be caused by this commit e1d523a

While the new .lp-content class was introduced to the Preview class, it's not being used for LivePreview:

Bildschirmfoto 2024-09-02 um 13 03 51

Steps to reproduce

  1. Install Solspace Calendar
  2. Configure a preview target for the default calendar (/admin/calendar/calendars/default)
  3. Create and save a valid event
  4. Open Live Preview

Expected behavior

All fields should be visible, the editor panel should have horizontal padding and can be scrolled.

Actual behavior

Due to the missing padding, some fields are not fully visible. The panel cannot be scrolled.

Craft CMS version

5.2.0

PHP version

8.2

Operating system and version

No response

Database type and version

No response

Image driver and version

No response

Installed plugins and versions

  • "solspace/craft-calendar": "^5.0.7"
@brandonkelly
Copy link
Member

Thanks for reporting that! Fixed for the next release.

@brandonkelly
Copy link
Member

Craft 5.4.0 is out now with that fix. Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants