Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show a count/progress when updating Asset indexes #2934

Closed
ryanmasuga opened this issue May 30, 2018 · 3 comments
Closed

Show a count/progress when updating Asset indexes #2934

ryanmasuga opened this issue May 30, 2018 · 3 comments
Assignees
Labels
enhancement improvements to existing features

Comments

@ryanmasuga
Copy link

Description

Would it be possible to show actual numbers like “Indexing: 341/18405” near the progress bar when updating Asset indexes? That progress bar is nice looking, but when you run indexes that take upwards of 40 minutes on directories that have tens of thousands of assets in them, seeing real numbers would make me feel better.

Suggestion (before / after):

screen shot 2018-05-30 at 1 56 31 pm

Not sure how that would work when selecting multiple asset sources to index at the same time, but food for thought.

@andris-sevcenko andris-sevcenko self-assigned this May 30, 2018
@narration-sd
Copy link
Contributor

I think this is a sound idea, Ryan, and in fact I've had a minimally invasive PR which can make it straightforward to provide, in the hopper for a while -- think it got lost in the Craft 3 clusure needs.

I'll have a look shortly to see if it needs anything to be up to date with the current develop branch -- having done the necessary merges several times before -- #1931

I've been using the functionality in the way you're envisioning, to show progress on complex tasks I run on a remote database to Craft Entries agent which is 'out there' from a custom job, if not quite suitable for a standard store plugin. The screen display is pretty much just as you propose -- I highjacked the CP HUD to show this.

@narration-sd
Copy link
Contributor

CC: @andris-sevcenko ^^

@narration-sd
Copy link
Contributor

narration-sd commented May 30, 2018

Ok, PR re-merged with latest Craft dev-develop, and checked out via running up my Craft 3 conversion of the agent plugin. Much fun getting that vm sane again, naturally, but interesting to watch Craft 3 late adjustments sort of float by. I think I liked the shadowed CP tabs before they went away, but seem to recall there was a reason.

Mini-screenshots below show result of the PR working -- in the removing entries pic, the number decrements as blocks of Entries are removed: we are on 100 left out of 200 at beginning, added by four exercises of the Manual Posting button at 50 Entries created from remote ms-sql database content. In real life, the plugin back-ends an official furniture standards website in the UK.

Presume this shows as you wanted, @ryanmasuga .

The PR has an owner tag added to Jobs, besides the state which is giving the changing messages. This allows selective 'adjustments' (i.e. kills) on Jobs, which is also rather handy, keeping for example this agent's job/task safeties from interfering with Craft or anyone else's queued Jobs.

posting-entries

removing-entries

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement improvements to existing features
Projects
None yet
Development

No branches or pull requests

4 participants