[4.8.1]: Action update cart doesn't update shipping/tax

[smcyr]

What happened?

After upgrading from 4.7.2 to 4.8.1, the cart doesn't update the tax/shipping after the first time. From what I can see in the CartController, the recalculationMode is set to none before the order is saved, so the second time you update the cart, it doesn't recalculate.

CartController.php:

$this->_cart->recalculate();
$this->_cart->recalculationMode = Order::RECALCULATION_MODE_NONE;
...
if (!$this->_cart->validate($attributes, false) || !Craft::$app->getElements()->saveElement($this->_cart, false, false, $updateCartSearchIndexes)) {

From what I can see in the code, the problem is probably also present in Craft Commerce 5.3.2 because of the commit Move recalculation inside of cart controller

Craft CMS version

4.14.4

Craft Commerce version

4.8.1

[linear]

PT-2426 [4.8.1]: Action update cart doesn't update shipping/tax

[RitterKnightCreative]

Excellent spot. Spent the last hour or so trying to track this down myself based on when we updated the site. Client e-mailed wondering why a couple of orders weren't including shipping charges.

[smcyr]

Excellent spot. Spent the last hour or so trying to track this down myself based on when we updated the site. Client e-mailed wondering why a couple of orders weren't including shipping charges.

Same happened to us, our client contacted us with an order that didn't include the right tax and shipping in production. Downgrading didn't fix the issue immediatly, I also needed to update the column relcalculate in the table commerce_orders manually.

[RitterKnightCreative]

I was able to revert the CartController.php back to what it was before and that seems to have solved it as a temporary workaround. I'm honestly surprised this got past Pixel and Tonic's usually decent QA.

[lukeholder]

Apologies, we have release 4.8.1.1 and 5.3.2.1 which fixes this regression.

We will look into a better solution after the weekend.

[lukeholder]

We just released 5.3.2.2 and 4.8.1.2

This patch ensures that any affected carts have the correct recalculation mode set.