Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The issue with Matrix fields #1226

Closed
mofman opened this issue Jan 26, 2023 · 2 comments
Closed

The issue with Matrix fields #1226

mofman opened this issue Jan 26, 2023 · 2 comments
Labels

Comments

@mofman
Copy link

mofman commented Jan 26, 2023

The documentation explicitly says do not name the nodes for each block. eg.

<MatrixContent>
    <RichTextBlock>
        <Copy>Lorem ipsum...</Copy>
        <Caption>Some more text.</Caption>
    </RichTextBlock>

    <ImageBlock>
        <Image>img_fjords.jpg</Image>
    </ImageBlock>
</MatrixContent>

I still can't wrap my head around the approach in the documentation which is the following.

<MatrixContent>
    <MatrixBlock>
        <Copy>Lorem ipsum...</Copy>
        <Caption>Some more text.</Caption>
    </MatrixBlock>

    <MatrixBlock>
        <Image>img_fjords.jpg</Image>
    </MatrixBlock>
</MatrixContent>

This makes no sense to me, lets assume you have two blocks in your matrix that have identical fields names eg

Hero Block
Main Title, Main Image

Text & Image Block
Main Title, Main Image

There is abolutely no way for you to import content into these block in any sort of uniform way. The example the documention says you should not use is exactly the way it should be in my view?

@mofman mofman added the bug label Jan 26, 2023
@angrybrad
Copy link
Member

Resolved in b7c5c9e, 8931ff6, and 0a53020

@brandonkelly
Copy link
Member

Feed Me 5.1.0 has been released with the fix for this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants