Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can not add false override for feed settings #1380

Closed
tricki opened this issue Nov 17, 2023 · 1 comment
Closed

Can not add false override for feed settings #1380

tricki opened this issue Nov 17, 2023 · 1 comment
Assignees
Labels

Comments

@tricki
Copy link

tricki commented Nov 17, 2023

Description

I'm trying to disable the "Update search indexes" and "Backup" using the feed-me.php override config, but it's getting completely ignored.

I tracked it down to this line: https://github.com/craftcms/feed-me/blob/develop/src/services/Feeds.php#L296

I'd suggest that instead of checking the value, it should check if the key exists.

FYI the reason I want to disable those is because I have multiple feeds which get triggered at the same time, and I only want to do those operations for the one that runs last.

Steps to reproduce

  1. Set the feedOptions field in /config/feed-me.php to this:
[
    '1' => [
        'backup' => false,
    ]
]
  1. Create a new feed. On the "Create a new feed" page, note how the "Backup" toggle is active.

Additional info

  • Craft version: 4.5.10
  • PHP version: 8.0.30
  • Database driver & version: MariaDB 10.5.13
  • Plugins & versions: Feed Me 5.2.0
@angrybrad
Copy link
Member

Resolved in #1382 and will be included in the next release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants