fix(docker): prepending docker_exe to PATH #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
currently docker_exe was being appended to PATH which meant that given `docker_exe` configuration didnt take any precedence in case there are multiple `docker` instances on `PATH` (which seems to be case, at least in Ubuntu). By prepending provided path, if exists, takes precedence over other dirs in PATH.
viega
approved these changes
Oct 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Currently
docker_exewas being appended to PATH which meant that givendocker_execonfiguration didnt take any precedence in case there are multipledockerinstances onPATH(which seems to be case, at least in Ubuntu).By prepending provided path, if exists, takes precedence over other dirs in PATH.