Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: DOCKER_ANNOTATIONS and _IMAGE_ANNOTATIONS keys #452

Merged
merged 1 commit into from
Nov 26, 2024
Merged

Conversation

miki725
Copy link
Contributor

@miki725 miki725 commented Nov 25, 2024

Description

Docker supports adding OCI-style annotations which are stored per manifest, not per image config. During docker build, annotations can be provided via --annotation flag. Chalk now reports:

  • DOCKER_ANNOTATIONS - all --annotation flags used in CLI during build
  • _IMAGE_ANNOTATIONS - all found annotations in the registry for existing image

This will be used during lineage to recursively lookup base images and report some metadata about them.

Testing

➜ make tests args="test_docker.py::test_docker_labels --logs --pdb"

@miki725 miki725 requested a review from mbaltrusitis November 25, 2024 17:26
@miki725 miki725 marked this pull request as ready for review November 25, 2024 17:29
@miki725 miki725 requested a review from viega as a code owner November 25, 2024 17:29
Base automatically changed from digests to main November 26, 2024 13:56
Docker supports adding OCI-style annotations which are stored per
manifest, not per image config. During `docker build`, annotations can
be provided via `--annotation` flag. Chalk now reports:

* DOCKER_ANNOTATIONS - all `--annotation` flags used in CLI during build
* _IMAGE_ANNOTATIONS - all found annotations in the registry for
  existing image
@miki725 miki725 merged commit 2ce6197 into main Nov 26, 2024
4 checks passed
@miki725 miki725 deleted the annotations branch November 26, 2024 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants