fix(attestation): change default to NOT download cosign outside of setup flow #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
viega
previously approved these changes
Oct 10, 2023
| @@ -54,12 +56,12 @@ func install_cosign() { | |||
| return false | |||
| } | |||
|
|
|||
| func load_attestation_binary() { | |||
| func load_attestation_binary(download_if_not_present: bool) { | |||
There was a problem hiding this comment.
The : bool there should be redundant; I'd expect it to be inferred from the body since the body is unambiguous, but let me know if it does break (it certainly is fine to be explicit about the type here, I don't
think this needs to change).
MyNameIsMeerkat
deleted the
mynameismeerkat/fix_always_download_cosign
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Addressing issue raised in #27
Description
Chalk no longer downloads cosign by default outside of the
chalk setupflow. Previouslyplugins/system.nim's lookup of the location of the cosign binary caused cosign to be downloaded if it's path could not be determined. The default behaviour is now that lookups of cosign location will no longer initiate a download unless specifically requested. Thechalk setupflow will still download cosign as part of its setup process if it cannot be found locally.Testing
Run any chalk operation with --trace enabled and see that no cosign download takes place
Run
chalk --trace setupwith no local cosign and see that a download takes place