Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to Ruby 3 #28

Open
amotl opened this issue Feb 13, 2024 · 2 comments
Open

Update to Ruby 3 #28

amotl opened this issue Feb 13, 2024 · 2 comments

Comments

@amotl
Copy link
Member

amotl commented Feb 13, 2024

Hi there,

apparently, this repository is still on Ruby 2.

matrix:
os: [ "ubuntu-latest" ]
ruby-version: [ "2.4", "2.5", "2.6" ]

Coming from https://www.ruby-lang.org/en/downloads/releases/, I think it is safe to assume Ruby 2 is a thing of the past, and the repository should be upgraded to work with recent versions of Ruby 3? wdyt, @hammerhead?

With kind regards,
Andreas.

NB: This may also help to make GH-26 conclude without needing to bring in old Bundler releases still working on Ruby 2 in one way or another.

@hammerhead
Copy link
Member

hammerhead commented Feb 19, 2024

Hi,

Yes, upgrading to Ruby 3 totally makes sense. I think the currently used activerecord version doesn't support Ruby 3 yet, so we need to upgrade to a (slightly) more recent activerecord version first, before bumping Ruby itself.

Just opened #29 to at least fix the build right now on 2.7.

@amotl
Copy link
Member Author

amotl commented Feb 19, 2024

Thanks. Let me also cite your other discovery here:

The usage of BigDecimal.new within activerecord itself currently blocks further Ruby version upgrades. As per that link above, Ruby 2.7 is the latest version still supporting BigDecimal.new.

-- #29 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants