Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHP 8.4 support #547

Closed
mpociot opened this issue Sep 27, 2024 · 6 comments · Fixed by #556
Closed

PHP 8.4 support #547

mpociot opened this issue Sep 27, 2024 · 6 comments · Fixed by #556
Labels
enhancement New feature or request kind/php-and-sapi Issues related to php source and SAPI wip Work In Process

Comments

@mpociot
Copy link
Contributor

mpociot commented Sep 27, 2024

PHP 8.4 is now in the release candidate phase, with the official release scheduled for November 21.
It would be great if we get PHP 8.4 support in static-php

@crazywhalecc crazywhalecc added enhancement New feature or request kind/php-and-sapi Issues related to php source and SAPI labels Sep 27, 2024
@mpociot
Copy link
Contributor Author

mpociot commented Sep 27, 2024

The PHPMicro patches needed for this to begin with can be found in my fork
dixyes/phpmicro@master...mpociot:phpmicro:php-84-fixes

Sodium also seems to cause an issue, as the sodium.php file currently tries to remove all lines that contain -Wno-logical-op

Since PHP 8.4, this is no longer a single line though, which produces errors as the -Werror line remains in the config.m4 file after patching:

https://github.com/php/php-src/blob/master/ext/sodium/config.m4#L21-L22

@crazywhalecc crazywhalecc added the wip Work In Process label Sep 27, 2024
@crazywhalecc
Copy link
Owner

Seems dixyes/phpmicro#3 iconv part is duplicated.

Also, I haven't tested these patches yet, but if they work on Herd, we can use them first.

@mpociot
Copy link
Contributor Author

mpociot commented Sep 29, 2024

Yeah that PR is already outdated as it was based on an early alpha release.
I managed to compile 8.4.0RC1 for Herd. I had to disable some extensions that would need further investigation (like duplicate symbols with argon2 and sodium)

And then there are of course a couple of extensions that aren't ready / tagged yet like redis or imagick

@crazywhalecc
Copy link
Owner

If there are extension-independent phpmicro patches that need to be updated, we could use them and test them in advance.

For extensions, continue testing in the draft PR supporting 8.4 (will do) until most extensions are available.

@ikilobyte
Copy link
Contributor

@crazywhalecc PHP 8.4 already released

@crazywhalecc
Copy link
Owner

@ikilobyte Yeah, but this week I have no time to do with static-php project, some final tests needs to be done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request kind/php-and-sapi Issues related to php source and SAPI wip Work In Process
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants