Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add preflight check on windows to verify minimum RAM required for a preset #3631

Closed
anjannath opened this issue May 5, 2023 · 0 comments · Fixed by #3632
Closed

Add preflight check on windows to verify minimum RAM required for a preset #3631

anjannath opened this issue May 5, 2023 · 0 comments · Fixed by #3632

Comments

@anjannath
Copy link
Member

We are missing a check like below for windows platform:

{
configKeySuffix: "check-ram",
checkDescription: "Checking minimum RAM requirements",
check: func() error {
return validation.ValidateEnoughMemory(constants.GetDefaultMemory(preset))
},
fixDescription: fmt.Sprintf("crc requires at least %s to run", units.HumanSize(float64(constants.GetDefaultMemory(preset)*1024*1024))),
flags: NoFix,
labels: None,
},

@anjannath anjannath changed the title Add preflight check on windows to verify minimum RAM required or a preset Add preflight check on windows to verify minimum RAM required for a preset May 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant