Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In eval methods, cache evaluation results and check the cache before evaluating #125

Closed
jmilloy opened this issue Oct 22, 2018 · 2 comments
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@jmilloy
Copy link
Collaborator

jmilloy commented Oct 22, 2018

Description
Each eval method should return cached output without further evaluation if possible and should cache the output after evaluation. The coordinates hash for this should be agnostic to the dims order.

Solution
A decorator for eval methods.

@jmilloy jmilloy added the enhancement New feature or request label Oct 22, 2018
@jmilloy jmilloy self-assigned this Oct 22, 2018
@jmilloy jmilloy changed the title Coordinates hash should be agnostic to the dims order In eval methods, cache evaluation results and check the cache before evaluating Oct 22, 2018
@jmilloy
Copy link
Collaborator Author

jmilloy commented Oct 22, 2018

The decorator will also factor out a few other things from the eval method.

@jmilloy jmilloy added this to the 0.2.1 milestone Nov 1, 2018
@jmilloy
Copy link
Collaborator Author

jmilloy commented Nov 1, 2018

See also #140

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants