Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert segment_lengths when transforming lat and lon coordinates #252

Closed
jmilloy opened this issue Apr 28, 2019 · 2 comments
Closed

Convert segment_lengths when transforming lat and lon coordinates #252

jmilloy opened this issue Apr 28, 2019 · 2 comments
Labels
enhancement New feature or request

Comments

@jmilloy
Copy link
Collaborator

jmilloy commented Apr 28, 2019

Description
The segment_lengths of lat and lon coordinates need to be transformed when the coordinates are transformed. Currently, a warning is issued. The segment_lengths for alt coordinates are converted using the alt_units and/or proj4 vunits, when applicable, and we may be able to do the same for lat and lon using the proj4 +units, though I'm not sure if this will always be possible.

This may be an intractable issue. It is not clear to me if the segments will even make sense when transformed between some reference systems.

Notes:

  • this does not apply when ctype='point'.
  • it may be useful to consider this issue along with Interpolation ignores ctype #238
  • RotatedCoordinates has a similar and possibly intractable issue with segment_lengths (especially when converted to DependentCoordinates); segment lengths are not handled correctly there as well.
@jmilloy jmilloy added the enhancement New feature or request label Apr 28, 2019
@jmilloy
Copy link
Collaborator Author

jmilloy commented Jan 13, 2020

I don't think it is possible to do this in most cases. I am still strongly in favor of removing segment_lengths from Coordinates (#266), which would "solve" this issue.

@jmilloy
Copy link
Collaborator Author

jmilloy commented Jan 24, 2020

We are going to remove segments from Coordinates, so the transform will not need to handle them. See #357.

@jmilloy jmilloy closed this as completed Jan 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant