WIP: Google analytics added #64
Conversation
…e license chooser and the help section
There was a problem hiding this comment.
Overall, a good start! I would look at the GA implementation in cccatalog-frontend and consider modeling some of how it works in your implementation. I would like to see some events for the HTMLGenerator so we can get an idea of how much people are using the copy buttons, and how much people are using the "extra information" fields.
| @@ -383,6 +383,50 @@ export default { | |||
| isModal5Active: false, | |||
| isModal6Active: false | |||
| } | |||
| }, | |||
| watch: { | |||
There was a problem hiding this comment.
Please try to find a better way to do this, instead of having six separate functions, I would rather have one function and pass the eventLabel as a parameter.
|
|
||
| To update the dist bundle, run ```$ npm run build```, and copy the generated files from `./dist/` to `./docs/`, taking care to not delete the CNAME file in `./docs/`. | ||
|
|
||
| Add your Google Analyitics id in `src/main.js`: |
There was a problem hiding this comment.
Please remove this section, I would like the analytics to be disabled entirely when in a dev environment by default to avoid sending events that are not from the deployed chooser.
Bonus points if you can find a way to enable the event sending functionality explicitly with a flag on npm run start or npm run dev to allow for testing of analytics code when needed.
Fixes #62
Description
Added vue-analytics and added events for help and license chooser and a page call when app is opened.
Checklist:
Update index.md).masterbranch of the repository.visible errors.
Developer Certificate of Origin
Version 1.1
Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129
Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.
Developer's Certificate of Origin 1.1
By making a contribution to this project, I certify that:
(a) The contribution was created in whole or in part by me and I
have the right to submit it under the open source license
indicated in the file; or
(b) The contribution is based upon previous work that, to the best
of my knowledge, is covered under an appropriate open source
license and I have the right under that license to submit that
work with modifications, whether created in whole or in part
by me, under the same open source license (unless I am
permitted to submit under a different license), as indicated
in the file; or
(c) The contribution was provided directly to me by some other
person who certified (a), (b) or (c) and I have not modified
it.
(d) I understand and agree that this project and the contribution
are public and that a record of the contribution (including all
personal information I submit with it, including my sign-off) is
maintained indefinitely and may be redistributed consistent with
this project or the open source license(s) involved.