Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

trex run build generates incomplete href attribute(s) #52

Closed
michael-spengler opened this issue Mar 4, 2022 · 3 comments
Closed

trex run build generates incomplete href attribute(s) #52

michael-spengler opened this issue Mar 4, 2022 · 3 comments
Labels
good first issue Good for newcomers

Comments

@michael-spengler
Copy link
Collaborator

michael-spengler commented Mar 4, 2022 •
edited
Loading

... e.g.
link rel="stylesheet" href="/... instead of
link rel="stylesheet" href="./...

this is not a problem if we serve the page e.g. via https://deno.land/x/opine --> it is however a problem if we serve the page via github pages or via visual studio code live server, ...?
@michael-spengler michael-spengler added the good first issue Good for newcomers label Mar 4, 2022
@michael-spengler
Copy link
Collaborator Author

we used the following potentially relevant version:
deno 1.17.3 (release, x86_64-apple-darwin)
v8 9.7.106.15
typescript 4.5.2

@michael-spengler
Copy link
Collaborator Author

this could be fixed by updating

Snel/src/cli/prepare.ts

Line 70 in 3df2452

// normalize path ./example to /example

@silas-pohl
Copy link

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@michael-spengler @silas-pohl