Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] When doing dry run it still marks the job as DONE (green blob) even if there are ugly files in the repo #52

Closed
Niedzwiedzw opened this issue May 12, 2021 · 2 comments · Fixed by #48
Labels
bug Something isn't working duplicate This issue or pull request already exists

Comments

@Niedzwiedzw
Copy link

# This is a basic workflow to help you get started with Actions

name: CI

# Controls when the action will run. 
on:
  # Triggers the workflow on push or pull request events but only for the master branch
  pull_request:
    branches: [ staging ]

# A workflow run is made up of one or more jobs that can run sequentially or in parallel
jobs:
  # This workflow contains a single job called "build"
  prettier:
    runs-on: ubuntu-latest

    steps:
    - name: Checkout
      uses: actions/checkout@v2
      with:
        # Make sure the actual branch is checked out when running on pull requests
        ref: ${{ github.head_ref }}

    - name: Check code style
      uses: creyD/prettier_action@v3.3
      with:
        # This part is also where you can pass other options, for example:
        dry: true
        prettier_options: "-c src/**/*.{ts,vue}"
      env:
        GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}

despite warnings being printed the job doesn't fail

@Niedzwiedzw Niedzwiedzw added the bug Something isn't working label May 12, 2021
@bicobus
Copy link

bicobus commented Jun 1, 2021

I believe the dry option still requires the local files to be changed, so the action can check if they are different.

So my guess is to either use prettier_options: -w and dry switch to True, or just prettier_options: -c.

@creyD creyD added the duplicate This issue or pull request already exists label Jul 15, 2021
@creyD
Copy link
Owner

creyD commented Jul 15, 2021

#37 is the same issue, right?

@creyD creyD linked a pull request Sep 7, 2021 that will close this issue
@creyD creyD closed this as completed in #48 Sep 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working duplicate This issue or pull request already exists
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants