Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add reporter to http.req metric & event #1514

Open
ricksalsa opened this issue Jun 7, 2023 · 3 comments
Open

Add reporter to http.req metric & event #1514

ricksalsa opened this issue Jun 7, 2023 · 3 comments
Labels
enhancement New feature or request
Milestone

Comments

@ricksalsa
Copy link
Collaborator

AppScope captures inbound and outbound HTTP requests and generates http.req metric and event. Without a dimension, such as reporter, it is difficult to identify the origin of the request/response.

Adding a dimension such as reporter, users using either metrics or events can determine if the request was inbound (to the instrumented app) or outbound (generated by the instrumented app).

@ricksalsa ricksalsa added the enhancement New feature or request label Jun 7, 2023
@ricksalsa
Copy link
Collaborator Author

Adding a dimension/label for reporter can help users determine requests made in and out of an instrumented application.

Set the value to client if it originated from the instrumented app, server if it is inbound to the instrumented app, or unknown if its origin is not known.

@iapaddler
Copy link
Contributor

reporter is client or server?

@ricksalsa
Copy link
Collaborator Author

reporter is client or server?

client, server or unknown in case of an error where we don't know the origin.

Can we confirm the origin for our http.duration.server and http.duration.client metrics as well?

@ricksalsa ricksalsa added this to the 1.4.0 milestone Jun 8, 2023
@ricksalsa ricksalsa moved this from 🔖 To Do to 🏗 In progress in AppScope 1.4.0 Release (Summer 23) Jun 8, 2023
@jrcheli jrcheli moved this from 🏗 In progress to 🔖 To Do in AppScope 1.4.0 Release (Summer 23) Jul 6, 2023
@ricksalsa ricksalsa modified the milestones: 1.4.0, 1.5.0 Jul 6, 2023
@ricksalsa ricksalsa modified the milestones: 1.5.0, 1.4.1, 1.4.2 Jul 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants