Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix stac-model readme #22

Merged
merged 4 commits into from
May 13, 2024
Merged

fix stac-model readme #22

merged 4 commits into from
May 13, 2024

Conversation

fmigneault
Copy link
Collaborator

@fmigneault fmigneault commented May 13, 2024

Description

  • fix invalid links in stac-model readme
  • adjust specific readme of STAC Model for pypi

Rather than modifying all the links in https://github.com/crim-ca/mlm-extension/blob/main/README.md to use full URLs (see #15), the PyPI package distribution is modified to point at https://github.com/crim-ca/mlm-extension/blob/main/README_STAC_MODEL.md

Doing so, the corresponding links inside that README_STAC_MODEL.md are adjusted as expected.

Related Issue

Type of Change

  • 📚 Examples, docs, tutorials or dependencies update;
  • 🔧 Bug fix (non-breaking change which fixes an issue);
  • 🥂 Improvement (non-breaking change which improves an existing feature);
  • 🚀 New feature (non-breaking change which adds functionality);
  • 💥 Breaking change (fix or feature that would cause existing functionality to change);
  • 🔐 Security fix.

Checklist

  • I've read the CONTRIBUTING.md guide;
  • I've updated the code style using make codestyle;
  • I've written tests for all new methods and classes that I created;
  • I've written the docstring in Google format for all the methods and classes that I used.

@fmigneault fmigneault requested a review from rbavery May 13, 2024 14:25
@fmigneault fmigneault self-assigned this May 13, 2024
@fmigneault fmigneault changed the title fix stac-model fix stac-model readme May 13, 2024
Copy link
Collaborator

@rbavery rbavery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! link changes look good and as well as the safety policy.

@fmigneault fmigneault merged commit 18be64d into main May 13, 2024
8 checks passed
@fmigneault fmigneault deleted the fix-readme-links branch May 13, 2024 16:17
@fmigneault
Copy link
Collaborator Author

fmigneault commented May 13, 2024

@rbavery Do you want to give a shot at publishing a stac-model-v0.1.3stac-model-v0.1.4 release?

edit: seems stac-model-v0.1.3 is still not published on PyPI although released in the repo.

@fmigneault fmigneault mentioned this pull request May 13, 2024
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Invalid documentation URLs on PyPI
2 participants