Handle escaped characters in image file names, fixes 247even#7.

cristim · Oct 11, 2016 · e911532 · e911532
1 parent cf10cbb
commit e911532
Show file tree

Hide file tree

Showing 5 changed files with 28 additions and 1 deletion.
diff --git a/.gitignore b/.gitignore
@@ -0,0 +1 @@
+node_modules
diff --git a/index.js b/index.js
@@ -33,7 +33,7 @@ module.exports = function() {
 						var mtype = mime.lookup(spath);
 						if (mtype != 'application/octet-stream') {
 							console.log(mtype);
-							var sfile = fs.readFileSync(spath);
+							var sfile = fs.readFileSync(unescape(spath));
 							var simg64 = new Buffer(sfile).toString('base64');
 							this.attr('src', 'data:' + mtype + ';base64,' + simg64);
 						}

diff --git a/test/fixtures/directory with spaces/clock with escaped spaces in filename.png b/test/fixtures/directory with spaces/clock with escaped spaces in filename.png
diff --git a/test/fixtures/input with spaces in filename.html b/test/fixtures/input with spaces in filename.html
@@ -0,0 +1,3 @@
+<body>
+	<img src="directory%20with%20spaces/clock%20with%20escaped%20spaces%20in%20filename.png" />
+</body>
diff --git a/test/test.js b/test/test.js
@@ -29,5 +29,28 @@ describe('gulp-img64', function() {
 
 		});
 
+		it('should support escaped characters in image file names', function(done) {
+
+			var filename = path.join(__dirname, '/fixtures/input with spaces in filename.html');
+
+			var input = new gutil.File({
+				base: path.dirname(filename),
+				path: filename,
+				contents: new Buffer(fs.readFileSync(filename, 'utf8'))
+			});
+
+			var stream = img64();
+
+			stream.on('data', function(newFile) {
+				assert.equal(String(newFile.contents), fs.readFileSync(path.join(__dirname, '/fixtures/output.html'), 'utf8'));
+				done();
+			});
+
+			stream.write(input);
+
+		});
+
+
+
 	});
 });