Debug update and remove setConfig hook (prebid#4007)

* Debug update and remove setConfig hook * fix config failing on circular dependency with utils
criteo-forks · Jul 30, 2019 · 0e40b77 · 0e40b77
1 parent 5c0b06d
commit 0e40b77
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 12 deletions.
diff --git a/src/config.js b/src/config.js
@@ -10,10 +10,12 @@
 import { isValidPriceConfig } from './cpmBucketManager';
 import find from 'core-js/library/fn/array/find';
 import includes from 'core-js/library/fn/array/includes';
-import { hook } from './hook';
+import { parseQS } from './url';
+
 const utils = require('./utils');
+const CONSTANTS = require('./constants');
 
-const DEFAULT_DEBUG = false;
+const DEFAULT_DEBUG = (parseQS(window.location.search)[CONSTANTS.DEBUG_MODE] || '').toUpperCase() === 'TRUE';
 const DEFAULT_BIDDER_TIMEOUT = 3000;
 const DEFAULT_PUBLISHER_DOMAIN = window.location.origin;
 const DEFAULT_ENABLE_SEND_ALL_BIDS = true;
@@ -231,7 +233,7 @@ export function newConfig() {
    * Sets configuration given an object containing key-value pairs and calls
    * listeners that were added by the `subscribe` function
    */
-  let setConfig = hook('async', function setConfig(options) {
+  function setConfig(options) {
     if (typeof options !== 'object') {
       utils.logError('setConfig options must be an object');
       return;
@@ -251,7 +253,7 @@ export function newConfig() {
     });
 
     callSubscribers(topicalConfig);
-  });
+  }
 
   /**
    * Sets configuration defaults which setConfig values can be applied on top of

diff --git a/src/utils.js b/src/utils.js
@@ -5,8 +5,6 @@ import includes from 'core-js/library/fn/array/includes';
 import { parse } from './url';
 const CONSTANTS = require('./constants');
 
-var _loggingChecked = false;
-
 var tArr = 'Array';
 var tStr = 'String';
 var tFn = 'Function';
@@ -354,12 +352,6 @@ export function hasConsoleLogger() {
 }
 
 export function debugTurnedOn() {
-  if (config.getConfig('debug') === false && _loggingChecked === false) {
-    const debug = getParameterByName(CONSTANTS.DEBUG_MODE).toUpperCase() === 'TRUE';
-    config.setConfig({ debug });
-    _loggingChecked = true;
-  }
-
   return !!config.getConfig('debug');
 }
 

diff --git a/test/spec/debugging_spec.js b/test/spec/debugging_spec.js
@@ -13,6 +13,7 @@ describe('bid overrides', function () {
 
   afterEach(function () {
     window.sessionStorage.clear();
+    config.resetConfig();
     sandbox.restore();
   });