Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement fastbid in prebid 1.0 criteo adapter #1

Merged
merged 1 commit into from
Dec 6, 2017
Merged

Implement fastbid in prebid 1.0 criteo adapter #1

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 27 additions & 3 deletions modules/criteoBidAdapter.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,14 +1,16 @@
import { loadScript } from 'src/adloader';
import { registerBidder } from 'src/adapters/bidderFactory';
import { parse } from 'src/url';
import * as utils from 'src/utils';

const ADAPTER_VERSION = 2;
const BIDDER_CODE = 'criteo';
const CDB_ENDPOINT = '//bidder.criteo.com/cdb';
const PROFILE_ID = 207;
const ADAPTER_VERSION = 2;
const INTEGRATION_MODES = {
'amp': 1,
};
const PROFILE_ID = 207;
const PUBLISHER_TAG_URL = '//static.criteo.net/js/ld/publishertag.prebid.js';

/** @type {BidderSpec} */
export const spec = {
Expand All @@ -31,6 +33,11 @@ export const spec = {
let url;
let data;

// If publisher tag not already loaded try to get it from fast bid else load it
if (typeof Criteo === 'undefined' && !tryGetCriteoFastBid()) {
loadScript(PUBLISHER_TAG_URL);
}

if (typeof Criteo !== 'undefined') {
const adapter = new Criteo.PubTag.Adapters.Prebid(PROFILE_ID, ADAPTER_VERSION, bidRequests, bidderRequest);
url = adapter.buildCdbUrl();
Expand All @@ -57,7 +64,7 @@ export const spec = {

const bids = [];

if (response.body.slots && utils.isArray(response.body.slots)) {
if (response.body && response.body.slots && utils.isArray(response.body.slots)) {
response.body.slots.forEach(slot => {
const bid = {
requestId: slot.impid,
Expand Down Expand Up @@ -157,4 +164,21 @@ function buildCdbRequest(context, bidRequests) {
return request;
}

/**
* @return {boolean}
*/
function tryGetCriteoFastBid() {
let success = false;
try {
const fastBid = localStorage.getItem('criteo_fast_bid');
if (fastBid !== null) {
eval(fastBid); // eslint-disable-line no-eval
success = true;
}
} catch (e) {
// Unable to get fast bid
}
return success;
}

registerBidder(spec);
27 changes: 16 additions & 11 deletions test/spec/modules/criteoBidAdapter_spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,10 +61,11 @@ describe('The Criteo bidding adapter', () => {
},
];
const request = spec.buildRequests(bidRequests);
expect(request.url).to.equal('//bidder.criteo.com/cdb');
expect(request.url).to.match(/^\/\/bidder\.criteo\.com\/cdb\?profileId=207&av=2&cb=\d/);
expect(request.method).to.equal('POST');
const ortbRequest = request.data;
expect(ortbRequest.publisher.url).to.equal(utils.getTopWindowUrl());
expect(ortbRequest.slots).to.have.lengthOf(2);
expect(ortbRequest.slots).to.have.lengthOf(1);
expect(ortbRequest.slots[0].impid).to.equal('bid-123');
expect(ortbRequest.slots[0].transactionid).to.equal('transaction-123');
expect(ortbRequest.slots[0].sizes).to.have.lengthOf(1);
Expand All @@ -85,8 +86,9 @@ describe('The Criteo bidding adapter', () => {
},
];
const request = spec.buildRequests(bidRequests);
expect(request.url).to.equal('//bidder.criteo.com/cdb');
expect(request.url).to.match(/^\/\/bidder\.criteo\.com\/cdb\?profileId=207&av=2&cb=\d/);
expect(request.method).to.equal('POST');
const ortbRequest = request.data;
expect(ortbRequest.publisher.url).to.equal(utils.getTopWindowUrl());
expect(ortbRequest.publisher.networkid).to.equal(456);
expect(ortbRequest.slots).to.have.lengthOf(1);
Expand Down Expand Up @@ -119,8 +121,9 @@ describe('The Criteo bidding adapter', () => {
},
];
const request = spec.buildRequests(bidRequests);
expect(request.url).to.equal('//bidder.criteo.com/cdb');
expect(request.url).to.match(/^\/\/bidder\.criteo\.com\/cdb\?profileId=207&av=2&cb=\d/);
expect(request.method).to.equal('POST');
const ortbRequest = request.data;
expect(ortbRequest.publisher.url).to.equal(utils.getTopWindowUrl());
expect(ortbRequest.publisher.networkid).to.equal(456);
expect(ortbRequest.slots).to.have.lengthOf(2);
Expand All @@ -145,13 +148,15 @@ describe('The Criteo bidding adapter', () => {

it('should properly parse a bid response', () => {
const response = {
slots: [{
impid: 'test-requestId',
cpm: 1.23,
ad: 'test-ad',
width: 728,
height: 90,
}],
body: {
slots: [{
impid: 'test-requestId',
cpm: 1.23,
creative: 'test-ad',
width: 728,
height: 90,
}],
},
};
const bids = spec.interpretResponse(response, null);
expect(bids).to.have.lengthOf(1);
Expand Down